Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309409: Update HttpInputStreamTest and BodyProcessorInputStreamTest to use hg.openjdk.org #14302

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Jun 4, 2023

Can I please get a review of this test-only change which updates these manual tests to use https://hg.openjdk.org instead of http://hg.openjdk.java.net?

I've run these manual tests locally and they now pass with this change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309409: Update HttpInputStreamTest and BodyProcessorInputStreamTest to use hg.openjdk.org

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14302/head:pull/14302
$ git checkout pull/14302

Update a local copy of the PR:
$ git checkout pull/14302
$ git pull https://git.openjdk.org/jdk.git pull/14302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14302

View PR using the GUI difftool:
$ git pr show -t 14302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14302.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2023

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2023
@openjdk
Copy link

openjdk bot commented Jun 4, 2023

@jaikiran The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jun 4, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2023

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing that Jaikiran. LGTM!

@openjdk
Copy link

openjdk bot commented Jun 4, 2023

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309409: Update HttpInputStreamTest and BodyProcessorInputStreamTest to use hg.openjdk.org

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 4, 2023
@jaikiran
Copy link
Member Author

jaikiran commented Jun 4, 2023

Thank you Daniel for the quick review. Given that these are manual tests that don't get run in the CI (or github actions) and now that they are passing locally, I'll go ahead and integrate this PR.

@jaikiran
Copy link
Member Author

jaikiran commented Jun 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 4, 2023

Going to push as commit ac1597b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 4, 2023
@openjdk openjdk bot closed this Jun 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2023
@openjdk
Copy link

openjdk bot commented Jun 4, 2023

@jaikiran Pushed as commit ac1597b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8309409 branch June 4, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
2 participants