8305104: Remove the old core reflection implementation

[mlchung]

JEP 416 integrated in JDK 18 and since then, only a couple minor issues has been reported. Those issues were related with exception being thrown with invalid arguments. We propose to remove the old core reflection implementation in JDK 22. The -Djdk.reflect.useDirectMethodHandle=false workaround to revert to the old implementation will stop to work.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8309635 to be approved

Issues

• JDK-8305104: Remove the old core reflection implementation (Enhancement - P4)
• JDK-8309635: Remove the old core reflection implementation (CSR)

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to d161a384
• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to fc164c71

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14371/head:pull/14371
$ git checkout pull/14371

Update a local copy of the PR:
$ git checkout pull/14371
$ git pull https://git.openjdk.org/jdk.git pull/14371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14371

View PR using the GUI difftool:
$ git pr show -t 14371

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14371.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung The following labels will be automatically applied to this pull request:

• core-libs
• hotspot
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (af4db44b)
• 02: Full - Incremental (fc164c71)
• 01: Full - Incremental (d161a384)
• 00: Full (73340aa9)

[mlchung]

/label remove security

[openjdk]

@mlchung
The security label was successfully removed.

[dholmes-ora]

Hotspot code and test changes look fine. Thanks.

[AlanBateman]

The old + new implementations have been in four releases, which is good for shaking out any regressions/issues. Removing the old implementation in JDK 22 is good.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305104: Remove the old core reflection implementation

Reviewed-by: dholmes, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[ExE-Boss]

Suggested change

	* 1. during VM early startup and method handle support is fully initialized
	* 2. a Java native method
	* 3. -Djdk.reflect.useNativeAccessorOnly=true is set
	* 4. the member takes a variable number of arguments and the last parameter
	* is an array (see details below)
	* 5. the member's method type has an arity >= 255
	* 1. during VM early startup before method handle support is fully initialized
	* 2. a Java native method
	* 3. -Djdk.reflect.useNativeAccessorOnly=true is set
	* 4. the member takes a variable number of arguments and the last parameter
	* is not an array (see details below)
	* 5. the member's method type has an arity >= 255

[mlchung]

Fixed. Thanks.

[mlchung]

/integrate

[openjdk]

Going to push as commit 9bfe415.
Since your change was applied there have been 42 commits pushed to the master branch:

• bfef3c3: 8309955: Matcher uses @SInCE {@inheritdoc}
• d7251c1: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory
• b5b5b7c: 8309884: missing @SInCE tags in com.sun.source.*
• 75dcc4e: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE
• bed9161: 8308474: DSA does not reset SecureRandom when initSign is called again
• 3eec179: 8309854: ciReplay TestServerVM test fails with Graal
• 1401087: 8309753: Include array classes in the output of -XX:+PrintSharedArchiveAndExit
• e138685: 8309882: LinkedHashMap adds an errant serializable field
• c0aa6bf: 8309390: [JVMCI] improve copying system properties into libgraal
• 63843b1: 8309907: Remove unused _print_gc_overhead_limit_would_be_exceeded
• ... and 32 more: https://git.openjdk.org/jdk/compare/16c3d53b1bb60b1c1570731041f564bf13b45098...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit 9bfe415.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.