8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory

[yaqsun]

Low risk, only test changes.
java.nio.file.NoSuchFileException: ./name1692782213124882428/link when it is a different volume/file system.
machine info:

文件系统       类型      容量  已用  可用 已用% 挂载点
devtmpfs       devtmpfs  7.9G     0  7.9G    0% /dev
tmpfs          tmpfs     7.9G  245M  7.7G    4% /dev/shm
tmpfs          tmpfs     7.9G  893M  7.1G   12% /run
tmpfs          tmpfs     5.0M   16K  5.0M    1% /run/lock
tmpfs          tmpfs     7.9G     0  7.9G    0% /sys/fs/cgroup
/dev/nvme0n1p3 xfs        42G   24G   18G   58% /
/dev/nvme0n1p5 xfs       147G   25G  123G   17% /data
/dev/nvme0n1p2 ext3      283M   42M  227M   16% /boot
/dev/nvme0n1p1 vfat      300M  724K  299M    1% /boot/efi
tmpfs          tmpfs     1.6G  160K  1.6G    1% /run/user/1001
/dev/sda1      ext4      1.8T  913G  827G   53% /home/loongson/test-file

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14436/head:pull/14436
$ git checkout pull/14436

Update a local copy of the PR:
$ git checkout pull/14436
$ git pull https://git.openjdk.org/jdk.git pull/14436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14436

View PR using the GUI difftool:
$ git pr show -t 14436

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14436.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@yaqsun The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (ec6a05c0)
• 02: Full - Incremental (bc2e7355)
• 01: Full - Incremental (83cd31e1)
• 00: Full (8f095202)

[AlanBateman]

The CopyAndMove test will re-run the copy/move tests when the jtreg work directory is on a different file system to tmp file system. It looks like this broke at some point but may not have been noticed. I've changed the JBS issue to make it clearer what this issue is about. Do you mind renaming the PR too?

[AlanBateman]

Would it be possible to try this an alternative fix? It shouldn't be necessary for dir2 to be absolute so creating the link to the sibling file should fix it too.

diff --git a/test/jdk/java/nio/file/Files/CopyAndMove.java b/test/jdk/java/nio/file/Files/CopyAndMove.java
index 8f6e7742356..b028c7d4864 100644
--- a/test/jdk/java/nio/file/Files/CopyAndMove.java
+++ b/test/jdk/java/nio/file/Files/CopyAndMove.java
@@ -909,7 +909,7 @@ public class CopyAndMove {
         if (supportsLinks) {
             source = createSourceFile(dir1);
             link = dir1.resolve("link");
-            createSymbolicLink(link, source);
+            createSymbolicLink(link, source.getFileName());
             target = getTargetFile(dir2);
             copyAndVerify(link, target);
             delete(link);

[openjdk]

@yaqsun Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[AlanBateman]

Looks okay. I'll assume you will update the copyright year on the test before you integrate.

[openjdk]

@yaqsun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

• db133db: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
• 353e581: 8309747: Update --release 21 symbol information for JDK 21 build 27
• d3d0dbc: 8309756: Occasional crashes with pipewire screen capture on Wayland
• 9216750: 8308643: Incorrect value of 'used' jvmstat counter
• 5c70516: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent
• 81bfd78: 8309632: JDK 21 RDP1 L10n resource files update
• 9f64a64: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated
• 4a5475c: 8309953: Strengthen and optimize oopDesc age methods
• 79ff72a: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException
• 3e0bbd2: 8285368: Overhaul doc-comment inheritance
• ... and 67 more: https://git.openjdk.org/jdk/compare/4d66d977450e083214da3dba6ad4ed851c6c1cb4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[AlanBateman]

@yaqsun Do need to use "/integrate" to integrate this change.

[yaqsun]

/integrate

[openjdk]

@yaqsun
Your change (at version ec6a05c) is now ready to be sponsored by a Committer.

[DamonFool]

/sponsor

[openjdk]

Going to push as commit cfae6ef.
Since your change was applied there have been 77 commits pushed to the master branch:

• db133db: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
• 353e581: 8309747: Update --release 21 symbol information for JDK 21 build 27
• d3d0dbc: 8309756: Occasional crashes with pipewire screen capture on Wayland
• 9216750: 8308643: Incorrect value of 'used' jvmstat counter
• 5c70516: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent
• 81bfd78: 8309632: JDK 21 RDP1 L10n resource files update
• 9f64a64: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated
• 4a5475c: 8309953: Strengthen and optimize oopDesc age methods
• 79ff72a: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException
• 3e0bbd2: 8285368: Overhaul doc-comment inheritance
• ... and 67 more: https://git.openjdk.org/jdk/compare/4d66d977450e083214da3dba6ad4ed851c6c1cb4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool @yaqsun Pushed as commit cfae6ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.