Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310019: MIPS builds are broken after JDK-8304913 #14471

Closed
wants to merge 4 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jun 14, 2023

Add mipsel and mips64el to the Architecture enum.
(Later to be backported to JDK 21)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310019: MIPS builds are broken after JDK-8304913 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14471/head:pull/14471
$ git checkout pull/14471

Update a local copy of the PR:
$ git checkout pull/14471
$ git pull https://git.openjdk.org/jdk.git pull/14471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14471

View PR using the GUI difftool:
$ git pr show -t 14471

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14471.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2023

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 14, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310019: MIPS builds are broken after JDK-8304913

Reviewed-by: phh, shade, aoqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 3e0bbd2: 8285368: Overhaul doc-comment inheritance
  • 3eeb681: 8167252: Some of Charset.availableCharsets() does not contain itself
  • 653a8d0: 8310129: SetupNativeCompilation LIBS should match the order of the other parameters
  • 947f149: 8308444: LoadStoreNode::result_not_used() is too conservative
  • 8b4af46: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • 0038491: 8309978: [x64] Fix useless padding
  • 5f3613e: 8309960: ParallelGC young collections very slow in DelayInducer
  • 83d9267: 8303513: C2: LoadKlassNode::make fails with 'expecting TypeKlassPtr'
  • de8aca2: 8307907: [ppc] Remove RTM locking implementation
  • 4c0e164: 8309717: C2: Remove Arena::move_contents usage
  • ... and 19 more: https://git.openjdk.org/jdk/compare/d7251c1755779f8c4fdeac16ccb797ed45b1dfd4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 14, 2023
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at how other platforms do it, I think this patch is incomplete. See e.g. ARM32 patch: 83c096d

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. We want/need the original reporter to confirm it works now?

@theaoqi
Copy link
Member

theaoqi commented Jun 15, 2023

Looks fine. We want/need the original reporter to confirm it works now?

Native build linux-mips64el-zero-release passed after the fix. I'm not the original reporter.

Copy link
Member

@theaoqi theaoqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the test passed.

@vpa1977
Copy link
Contributor

vpa1977 commented Jun 18, 2023

mipsel and mips64el builds were successful after applying this MR patch.

@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

Going to push as commit 33c6ec9.
Since your change was applied there have been 68 commits pushed to the master branch:

  • e08e94f: 8310266: JFR: Refactor after 'view' command
  • f8f8bfb: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines
  • 7d4b77a: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • b896e3e: 8310146: Removing unused PerfLongVariant::_sampled
  • d2a858e: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode()
  • 4229baf: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
  • 266f983: 8308855: ARM32: TestBooleanVector crashes after 8300257
  • 6a63bad: 8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX
  • 6473a7d: 8310107: os::trace_page_sizes_for_requested_size should name alignment as requested page size
  • 02aaab1: 8310126: C1: Missing receiver null check in Reference::get intrinsic
  • ... and 58 more: https://git.openjdk.org/jdk/compare/d7251c1755779f8c4fdeac16ccb797ed45b1dfd4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2023
@openjdk openjdk bot closed this Jun 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@RogerRiggs Pushed as commit 33c6ec9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev
Copy link
Member

Hey @RogerRiggs, could you ask bots to backport to JDK 21? I'll then review that one as well.

@RogerRiggs
Copy link
Contributor Author

@shipilev Thanks for the reminder;
Backport PR openjdk/jdk21#40

@RogerRiggs RogerRiggs deleted the 8304913-mipsel-arch branch December 11, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

5 participants