-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8310019: MIPS builds are broken after JDK-8304913 #14471
Conversation
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at how other platforms do it, I think this patch is incomplete. See e.g. ARM32 patch: 83c096d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. We want/need the original reporter to confirm it works now?
Native build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the test passed.
/integrate |
Going to push as commit 33c6ec9.
Your commit was automatically rebased without conflicts. |
@RogerRiggs Pushed as commit 33c6ec9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hey @RogerRiggs, could you ask bots to backport to JDK 21? I'll then review that one as well. |
@shipilev Thanks for the reminder; |
Add mipsel and mips64el to the Architecture enum.
(Later to be backported to JDK 21)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14471/head:pull/14471
$ git checkout pull/14471
Update a local copy of the PR:
$ git checkout pull/14471
$ git pull https://git.openjdk.org/jdk.git pull/14471/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14471
View PR using the GUI difftool:
$ git pr show -t 14471
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14471.diff
Webrev
Link to Webrev Comment