8310027: Fix -Wconversion warnings in nmethod and compiledMethod related code

[coleenp]

This change adds casts to nmethod and compiled method offset and size functions that return int, and checked_casts where it's not obvious or already checked that the cast is correct.
Tested with tier1 on Oracle platforms, and tier1-4 linux and windows.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310027: Fix -Wconversion warnings in nmethod and compiledMethod related code (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Frederic Parain (@fparain - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14505/head:pull/14505
$ git checkout pull/14505

Update a local copy of the PR:
$ git checkout pull/14505
$ git pull https://git.openjdk.org/jdk.git pull/14505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14505

View PR using the GUI difftool:
$ git pr show -t 14505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14505.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (32761fe7)

[coleenp]

/label add hotspot-runtime

[openjdk]

@coleenp
The hotspot-runtime label was successfully added.

[vnkozlov]

Looks good.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310027: Fix -Wconversion warnings in nmethod and compiledMethod related code

Reviewed-by: kvn, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 108 new commits pushed to the master branch:

• 4ca548f: 8310326: Incorrect position of the synthetic unnamed class
• a059576: 8310187: Improve Generational ZGC jtreg testing
• 9a68ec8: 8219357: G1: G1GCPhaseTimes::debug_phase uses unnecessary ResourceMark
• 0878872: 8310020: MacroAssembler::call_VM(_leaf) doesn't consistently check for conflict with C calling convention.
• 79069c5: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
• 96a7db7: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
• b2e86ae: 8304478: Initial nroff manpage generation for JDK 22
• 7b45c8f: 8241800: Disable IPV6_MULTICAST_ALL to prevent interference from all multicast groups
• 137a5f7: 8310105: LoongArch64 builds are broken after JDK-8304913
• 33c6ec9: 8310019: MIPS builds are broken after JDK-8304913
• ... and 98 more: https://git.openjdk.org/jdk/compare/8e4e6b056c5ecf731f84a71e4e319d2a27734ec2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Vladimir.

[fparain]

Looks good to me

[coleenp]

Thanks for reviewing, Fred.
/integrate

[openjdk]

Going to push as commit e1906e7.
Since your change was applied there have been 108 commits pushed to the master branch:

• 4ca548f: 8310326: Incorrect position of the synthetic unnamed class
• a059576: 8310187: Improve Generational ZGC jtreg testing
• 9a68ec8: 8219357: G1: G1GCPhaseTimes::debug_phase uses unnecessary ResourceMark
• 0878872: 8310020: MacroAssembler::call_VM(_leaf) doesn't consistently check for conflict with C calling convention.
• 79069c5: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
• 96a7db7: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
• b2e86ae: 8304478: Initial nroff manpage generation for JDK 22
• 7b45c8f: 8241800: Disable IPV6_MULTICAST_ALL to prevent interference from all multicast groups
• 137a5f7: 8310105: LoongArch64 builds are broken after JDK-8304913
• 33c6ec9: 8310019: MIPS builds are broken after JDK-8304913
• ... and 98 more: https://git.openjdk.org/jdk/compare/8e4e6b056c5ecf731f84a71e4e319d2a27734ec2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit e1906e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.