-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp #14550
Conversation
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and trivial.
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks @tstuefe ! /integrate |
Going to push as commit 96a7db7. |
@dholmes-ora Pushed as commit 96a7db7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk21 |
@dholmes-ora the backport was successfully created on the branch dholmes-ora-backport-96a7db7b in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late for this party, but I appreciate this change. Thanks!
Please review this trivial update to the comments in globals.hpp regarding the definition of EXPERIMENTAL flags.
Thanks.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14550/head:pull/14550
$ git checkout pull/14550
Update a local copy of the PR:
$ git checkout pull/14550
$ git pull https://git.openjdk.org/jdk.git pull/14550/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14550
View PR using the GUI difftool:
$ git pr show -t 14550
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14550.diff
Webrev
Link to Webrev Comment