8295210: IR framework should not whitelist -XX:-UseTLAB

[enothum]

Removed TLAB from the IR Framework whitelist. If TLAB allocations are disabled by -XX:-UseTLAB the IR verification can fail, therefore "TLAB" should not be withelisted. See JDK-8295210 for an example of such a failure.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295210: IR framework should not whitelist -XX:-UseTLAB (Bug - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14583/head:pull/14583
$ git checkout pull/14583

Update a local copy of the PR:
$ git checkout pull/14583
$ git pull https://git.openjdk.org/jdk.git pull/14583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14583

View PR using the GUI difftool:
$ git pr show -t 14583

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14583.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back enothum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@enothum The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fd3f06e9)

[TobiHartmann]

Looks good and trivial. Thanks for fixing.

[openjdk]

@enothum This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295210: IR framework should not whitelist -XX:-UseTLAB

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 7da3f19: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
• 8e04702: 8242152: SA does not include StackMapTables when dumping .class files
• 3bc475e: 8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt
• 3661cde: 8309853: StructuredTaskScope.join description improvements
• ac44ef1: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all
• 3be50da: 8310512: Cleanup indentation in jfc files
• f286e5a: 8310575: no @since for StandardDoclet
• 16a34e8: 8310384: Add hooks for custom image creation
• 226c6a0: 8309883: no @since info in com.sun.tools.javac package-info.java, Main.java
• fd1163d: 8310332: Fix -Wconversion warnings in MethodData
• ... and 5 more: https://git.openjdk.org/jdk/compare/574c6f0ebfdff86722a3659b91ec860a922ffc4d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[chhagedorn]

Looks good.

[enothum]

/integrate

[openjdk]

@enothum
Your change (at version fd3f06e) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 31dcda5.
Since your change was applied there have been 23 commits pushed to the master branch:

• 4772893: 8310581: retry_class_loading_during_parsing() is not used
• 5a82fa3: 8310577: Fix -Wconversion warnings in interpreter and oops
• 130a9f1: 8292704: sun/security/tools/jarsigner/compatibility/Compatibility.java use wrong key size for EC
• 0e4fde3: 8310453: Update javadoc of java.lang.Object
• 230bcb7: 8309685: Fix -Wconversion warnings in assembler and register code
• 370b8b2: 8310618: Test serviceability/sa/ClhsdbDumpclass.java fails after 8242152: 'StackMapTable:' missing from stdout/stderr
• 5a30fb6: 8310591: Missing @since tags in java.lang.foreign
• 8976ebf: 8310561: JFR: Unify decodeDescriptors(String, String)
• 7da3f19: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
• 8e04702: 8242152: SA does not include StackMapTables when dumping .class files
• ... and 13 more: https://git.openjdk.org/jdk/compare/574c6f0ebfdff86722a3659b91ec860a922ffc4d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @enothum Pushed as commit 31dcda5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.