JDK-8310975 java.util.FormatItemModifier should not be protected

[JimLaskey]

The nested class is incorrectly marked as protected.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310975: java.util.FormatItemModifier should not be protected (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14681/head:pull/14681
$ git checkout pull/14681

Update a local copy of the PR:
$ git checkout pull/14681
$ git pull https://git.openjdk.org/jdk.git pull/14681/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14681

View PR using the GUI difftool:
$ git pr show -t 14681

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14681.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (174a44cf)

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310975: java.util.FormatItemModifier should not be protected

Reviewed-by: alanb, darcy, iris, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• ec45bd6: 8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash
• 2bd4136: 8310849: Pattern matching for instanceof and arrayType cleanup in j.l.invoke and j.l.reflect
• 7ce967a: 8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp
• f6133ed: 8310890: Normalize identifier names

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JimLaskey]

/integrate

[openjdk]

Going to push as commit 315242b.
Since your change was applied there have been 6 commits pushed to the master branch:

• d6dd0dc: 8308452: Extend internal Architecture enum with byte order and address size
• fb283df: 8310828: java.sql java.sql.rowset packages have no @since info
• ec45bd6: 8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash
• 2bd4136: 8310849: Pattern matching for instanceof and arrayType cleanup in j.l.invoke and j.l.reflect
• 7ce967a: 8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp
• f6133ed: 8310890: Normalize identifier names

Your commit was automatically rebased without conflicts.

[openjdk]

@JimLaskey Pushed as commit 315242b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[JimLaskey]

/backport jdk21

[openjdk]

@JimLaskey the backport was successfully created on the branch JimLaskey-backport-315242b7 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 315242b7 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 27 Jun 2023 and was reviewed by Alan Bateman, Joe Darcy, Iris Clark and Lance Andersen.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-315242b7:JimLaskey-backport-315242b7
$ git checkout JimLaskey-backport-315242b7
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-315242b7