8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java

[quadhier]

This patch eliminates the usage of testcases.jar from TestMetaSpaceLog.java and removes this jar file.

As this email said, TestMetaSpaceLog.java (imported in JDK-8211123) tries to fill the metaspace, then do a full GC and check if metaspace size does shrink. It fills the metaspace by creating many new URLClassLoaders to load classes from an external jar file (testcases.jar).

Now we could use jdk.test.lib.compiler.InMemoryJavaCompiler and jdk.test.lib.ByteCodeLoader to achieve the same goal. In this way, we don't need this jar file at all and could remove it. (The similar idea has been proposed in JDK-8211255 and also discussed in the email thread mentioned above. But that issue was closed and not fixed for some unknown reasons :() Anyway, leaving a binary file in VCS is not good.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14804/head:pull/14804
$ git checkout pull/14804

Update a local copy of the PR:
$ git checkout pull/14804
$ git pull https://git.openjdk.org/jdk.git pull/14804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14804

View PR using the GUI difftool:
$ git pr show -t 14804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14804.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dqu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@quadhier The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4d22ca17)

[quadhier]

Hi @lkorinth, is this the change you had in mind? :P

[quadhier]

Looking for reviewers :D, thanks in advance!

[openjdk]

@quadhier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 296 new commits pushed to the master branch:

• dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
• a38fdaf: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.
• c1f4595: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem
• 90d795a: 8313141: Missing check for os_thread type in os_windows.cpp
• 6d18529: 8313795: Fix for JDK-8313564 breaks ppc and s390x builds
• ad6e9e7: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry
• b463c6d: 8311517: Add performance information to ArrayList javadoc
• b2add96: 8159527: Collections mutator methods should all be marked as optional operations
• 873d117: 8312623: SA add NestHost and NestMembers attributes when dumping class
• 017e0c7: 8310388: Shenandoah: Auxiliary bitmap is not madvised for THP
• ... and 286 more: https://git.openjdk.org/jdk/compare/9084b6c9d5b6550059fee39d6335fed467f1c45c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[quadhier]

Thanks very much for your review @albertnetymk !

[quadhier]

Thanks for @tschatzl 's review as well!

/integrate

[openjdk]

@quadhier
Your change (at version 4d22ca1) is now ready to be sponsored by a Committer.

[albertnetymk]

/sponsor

[openjdk]

Going to push as commit 6b9df03.
Since your change was applied there have been 472 commits pushed to the master branch:

• 3e1b1bf: 8314688: VM build without C1 fails after JDK-8313372
• 02ef859: 8313689: C2: compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java fails intermittently with -XX:-TieredCompilation
• ab86d23: 8250269: Replace ATTRIBUTE_ALIGNED with alignas
• a66b5df: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
• 87298d2: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
• 78f74bc: 8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64
• 17a19dc: 8311639: Replace currentTimeMillis() with nanoTime() in jtreg/gc
• 0b3f452: 8314161: G1: Fix -Wconversion warnings in G1CardSetConfiguration::_bitmap_hash_mask
• abac608: 8313962: G1: Refactor G1ConcurrentMark::_num_concurrent_workers
• 812f475: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
• ... and 462 more: https://git.openjdk.org/jdk/compare/9084b6c9d5b6550059fee39d6335fed467f1c45c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk @quadhier Pushed as commit 6b9df03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[quadhier]

Thanks for your sponsoring this, Albert!