New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8306040: HttpResponseInputStream.available() returns 1 on empty stream #14810
Conversation
👋 Welcome back vtewari! A progress list of the required criteria for merging this PR into |
if (iterator != null && iterator.hasNext()) return 1; | ||
if (buffers.isEmpty()) return 0; | ||
return 1; | ||
if (!buffers.isEmpty() && buffers.peek() != LAST_LIST ) return 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be:
if (iterator != null && iterator.hasNext() && Utils.hasRemaining(buffers)) return 1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean
if (iterator != null && iterator.hasNext() && Utils.hasRemaining(buffers.peek())) return 1; ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! Sorry ignore my suggestion. What you originally had seems reasonable. Give me some time to test.
Webrevs
|
@vyommani This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@dfuch can you please review this PR ?. |
Hi Vyom, sorry I had forgotten about this. In principle the fix looks good but the new test has some stability issue. It fails intermittently (and frequently) when run in the CI: java.lang.AssertionError: expected [1] but found [0] |
@vyommani This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 490 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit acaab6f.
Your commit was automatically rebased without conflicts. |
Please review the code change for JDK-8306040. In the overridden "available" method of "HttpResponseInputStream" we are returning 1 after exploring all the code path.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14810/head:pull/14810
$ git checkout pull/14810
Update a local copy of the PR:
$ git checkout pull/14810
$ git pull https://git.openjdk.org/jdk.git pull/14810/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14810
View PR using the GUI difftool:
$ git pr show -t 14810
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14810.diff
Webrev
Link to Webrev Comment