-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed #14884
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 0d2196f.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit 0d2196f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a test only update to a test for the JFR event jdk.VirtualThreadPinned event. The test we added in JDK 19 does 3 sleeps, one with a small duration, twice with a long duration. The test enables the event with a threshold of 500ms and expects there will be two events recorded; no event for the sleep with the small duration. In extreme cases, it's possible that the short sleep takes more than 500ms so an event is recorded and the test fails. The test is changed to drop the threshold, it's not needed. It's also changed to explicitly park to avoid the long sleeps. A drive-by change is to print the events to System.err rather than System.out so they are inlined with the JUnit output (the original test was TestNG where the output went to System.out).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14884/head:pull/14884
$ git checkout pull/14884
Update a local copy of the PR:
$ git checkout pull/14884
$ git pull https://git.openjdk.org/jdk.git pull/14884/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14884
View PR using the GUI difftool:
$ git pr show -t 14884
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14884.diff
Webrev
Link to Webrev Comment