Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8312530 Problemlist runtime/os/TestTrimNative.java #14983

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jul 22, 2023

Trivial patch to problemlist a test that fails intermittently on Oracle Linux 7.9


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312530: Problemlist runtime/os/TestTrimNative.java (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14983/head:pull/14983
$ git checkout pull/14983

Update a local copy of the PR:
$ git checkout pull/14983
$ git pull https://git.openjdk.org/jdk.git pull/14983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14983

View PR using the GUI difftool:
$ git pr show -t 14983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14983.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 22, 2023
@openjdk
Copy link

openjdk bot commented Jul 22, 2023

@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@tstuefe
Copy link
Member Author

tstuefe commented Jul 22, 2023

/label hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 22, 2023
@openjdk
Copy link

openjdk bot commented Jul 22, 2023

@tstuefe
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 22, 2023

Webrevs

@@ -98,6 +98,7 @@ runtime/os/TestTracePageSizes.java#compiler-options 8267460 linux-aarch64
runtime/os/TestTracePageSizes.java#G1 8267460 linux-aarch64
runtime/os/TestTracePageSizes.java#Parallel 8267460 linux-aarch64
runtime/os/TestTracePageSizes.java#Serial 8267460 linux-aarch64
runtime/os/TestTrimNative.java 8312525 linux-all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That entry won't work. It should be:

runtime/os/TestTrimNative.java#trimNative 8312525 linux-all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure in Mach5 is reported as "runtime/os/TestTrimNative.java#trimNative"
so you have to include the sub-test portion. As far as I can see, that's the only
sub-test that is failing.

FYI: Simply naming the test, e.g., "runtime/os/TestTrimNative.java" does NOT
disable all of the sub-tests.

Copy link
Member Author

@tstuefe tstuefe Jul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrgh. This should be something we should allow, maybe with wildcards.

Thanks, Dan, I changed the list to include all tests by name that could be possibly affected by this bug.

Copy link
Contributor

@AlanBateman AlanBateman Jul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODETOOLS-7902712 is one issue on this topic.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Jul 22, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312530: Problemlist runtime/os/TestTrimNative.java

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8d1ab57: 8301341: LinkedTransferQueue does not respect timeout for poll()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 22, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Jul 23, 2023

Thanks Dan!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2023

Going to push as commit 0487aa6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8d1ab57: 8301341: LinkedTransferQueue does not respect timeout for poll()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 23, 2023
@openjdk openjdk bot closed this Jul 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2023
@openjdk
Copy link

openjdk bot commented Jul 23, 2023

@tstuefe Pushed as commit 0487aa6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora
Copy link
Member

dholmes-ora commented Jul 23, 2023

Thanks for the quick fix @tstuefe , and the review @dcubed-ojdk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

4 participants