8311104: dangling-gsl warning in libwixhelper.cpp

[alexeysemenyukoracle]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311104: dangling-gsl warning in libwixhelper.cpp (Bug - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15044/head:pull/15044
$ git checkout pull/15044

Update a local copy of the PR:
$ git checkout pull/15044
$ git pull https://git.openjdk.org/jdk.git pull/15044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15044

View PR using the GUI difftool:
$ git pr show -t 15044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15044.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[alexeysemenyukoracle]

@sashamatveev please review

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (43fd7a38)

[sashamatveev]

I am not familiar with this warning. Does it mean that in original const LPCTSTR upgradeCodeStr = upgradeCode.toMsiString().c_str();, tstring retuned from toMsiString() will get destroyed right after c_str() completed? Which will make upgradeCodeStr invalid?

[alexeysemenyukoracle]

Yep, that is correct

[sashamatveev]

Looks good.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311104: dangling-gsl warning in libwixhelper.cpp

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 0ca2bfd.
Since your change was applied there have been 14 commits pushed to the master branch:

• c05ba48: 8313250: Exclude java/foreign/TestByteBuffer.java on AIX
• 169b6e3: 8313174: Create fewer predictable port clashes in management tests
• 8650026: 8310033: Clarify return value of Java Time compareTo methods
• 25058cd: 8312620: WSL Linux build crashes after JDK-8310233
• 8661b8e: 8312495: assert(0 <= i && i < _len) failed: illegal index after JDK-8287061 on big endian platforms
• 486c784: 8312433: HttpClient request fails due to connection being considered idle and closed
• 271417a: 8312579: [JVMCI] JVMCI support for virtual Vector API objects
• 44576a7: 8312466: /bin/nm usage in AIX makes needs -X64 flag
• 86821a7: 8312235: [JVMCI] ConstantPool should not force eager resolution
• 7cbab1f: 8312218: Print additional debug information when hitting assert(in_hash)
• ... and 4 more: https://git.openjdk.org/jdk/compare/4c2e54fb055bee0af5cd838fdd32a0f7902d51e3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 0ca2bfd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.