JDK-8312617: SIGSEGV in ConnectionGraph::verify_ram_nodes

[JohnTortugo]

• Return early from verify_ram_nodes if compilation is already failing.
• Add back check for failing() after eliminate_macro_nodes().
• Print additional diagnostic information when an unexpected user of RAM is encountered.

Tested with tier1-3 on Linux x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312617: SIGSEGV in ConnectionGraph::verify_ram_nodes (Bug - P2)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to b55cba76
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15048/head:pull/15048
$ git checkout pull/15048

Update a local copy of the PR:
$ git checkout pull/15048
$ git pull https://git.openjdk.org/jdk.git pull/15048/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15048

View PR using the GUI difftool:
$ git pr show -t 15048

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15048.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JohnTortugo The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (2e91dc5f)
• 01: Full - Incremental (b55cba76)
• 00: Full (d4ca4f2e)

[vnkozlov]

Use _compile->do_reduce_allocation_merges() instead of ReduceAllocationMerges in all places in escape.cpp. You removed one in adjust_scalar_replaceable_state(). I see an other at line 51 (_nodes field allocation) and at line 401 (where you don't need it - reducible_merges.size() > 0 check is enough)

[JohnTortugo]

Thanks for reviewing @vnkozlov

[vnkozlov]

Looks good.
You need second review.

[openjdk]

@JohnTortugo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312617: SIGSEGV in ConnectionGraph::verify_ram_nodes

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

• b093880: 8313322: RISC-V: implement MD5 intrinsic
• 19e2c8c: 8313593: Generational ZGC: NMT assert when the heap fails to expand
• 46fbedb: 8313402: C1: Incorrect LoadIndexed value numbering
• 6faf05c: 8311989: Test java/lang/Thread/virtual/Reflection.java timed out
• 5d1b911: 8310311: Serial: move Generation::contribute_scratch to DefNewGeneration
• 9454b2b: 8312591: GCC 6 build failure after JDK-8280982
• 6a853bb: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal
• e8471f6: 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList
• 528596f: 8310991: missing @SInCE tags in java.xml
• f14245b: 8312814: Compiler crash when template processor type is a captured wildcard
• ... and 68 more: https://git.openjdk.org/jdk/compare/cb82c954e3a37892ad504fcbb279bcf7619222dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[TobiHartmann]

Looks good to me otherwise. I'll run some testing and report back once it passed.

[TobiHartmann]

All tests passed.

[JohnTortugo]

Thank you for testing/reviewing @TobiHartmann / @vnkozlov

[JohnTortugo]

/integrate

[openjdk]

@JohnTortugo
Your change (at version 2e91dc5) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 6446792.
Since your change was applied there have been 78 commits pushed to the master branch:

• b093880: 8313322: RISC-V: implement MD5 intrinsic
• 19e2c8c: 8313593: Generational ZGC: NMT assert when the heap fails to expand
• 46fbedb: 8313402: C1: Incorrect LoadIndexed value numbering
• 6faf05c: 8311989: Test java/lang/Thread/virtual/Reflection.java timed out
• 5d1b911: 8310311: Serial: move Generation::contribute_scratch to DefNewGeneration
• 9454b2b: 8312591: GCC 6 build failure after JDK-8280982
• 6a853bb: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal
• e8471f6: 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList
• 528596f: 8310991: missing @SInCE tags in java.xml
• f14245b: 8312814: Compiler crash when template processor type is a captured wildcard
• ... and 68 more: https://git.openjdk.org/jdk/compare/cb82c954e3a37892ad504fcbb279bcf7619222dc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @JohnTortugo Pushed as commit 6446792.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.