-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311006: missing @since info in jdk.xml.dom #15129
Conversation
👋 Welcome back joehw! A progress list of the required criteria for merging this PR into |
@JoeWang-Java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@JoeWang-Java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 55 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks all! |
/integrate |
Going to push as commit d60352e.
Your commit was automatically rebased without conflicts. |
@JoeWang-Java Pushed as commit d60352e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a patch that add
@since
tags following existing convention for XML APIs in java.xml and jdk.xml.dom modules.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15129/head:pull/15129
$ git checkout pull/15129
Update a local copy of the PR:
$ git checkout pull/15129
$ git pull https://git.openjdk.org/jdk.git pull/15129/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15129
View PR using the GUI difftool:
$ git pr show -t 15129
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15129.diff
Webrev
Link to Webrev Comment