Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311006: missing @since info in jdk.xml.dom #15129

Closed
wants to merge 1 commit into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Aug 2, 2023

Please review a patch that add @since tags following existing convention for XML APIs in java.xml and jdk.xml.dom modules.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15129/head:pull/15129
$ git checkout pull/15129

Update a local copy of the PR:
$ git checkout pull/15129
$ git pull https://git.openjdk.org/jdk.git pull/15129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15129

View PR using the GUI difftool:
$ git pr show -t 15129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15129.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2023

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 2, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311006: missing @since info in jdk.xml.dom

Reviewed-by: iris, naoto, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • 0f2fce7: 8313632: ciEnv::dump_replay_data use fclose
  • ab1c212: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • c386091: 8312984: javac may crash on a record pattern with too few components
  • 3212b64: 8313582: Problemlist failing test on linux x86
  • bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
  • 3c920f9: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
  • 53ca75b: 8313312: Add missing classpath exception copyright header
  • 87d7e97: 8311031: JTable header border vertical lines are not aligned with data grid lines
  • 8248e35: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
  • ... and 45 more: https://git.openjdk.org/jdk/compare/4ae75cab53995a2ed36783a308b706f3f0f4e986...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 3, 2023
@JoeWang-Java
Copy link
Member Author

Thanks all!

@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

Going to push as commit d60352e.
Since your change was applied there have been 57 commits pushed to the master branch:

  • 4577147: 8313712: [BACKOUT] 8313632: ciEnv::dump_replay_data use fclose
  • bb3aac6: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel
  • 0f2fce7: 8313632: ciEnv::dump_replay_data use fclose
  • ab1c212: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • c386091: 8312984: javac may crash on a record pattern with too few components
  • 3212b64: 8313582: Problemlist failing test on linux x86
  • bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
  • 3c920f9: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
  • 53ca75b: 8313312: Add missing classpath exception copyright header
  • ... and 47 more: https://git.openjdk.org/jdk/compare/4ae75cab53995a2ed36783a308b706f3f0f4e986...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2023
@openjdk openjdk bot closed this Aug 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@JoeWang-Java Pushed as commit d60352e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8311006 branch August 8, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

4 participants