8315073: Zero build on macOS fails after JDK-8303852

[shqking]

It might be one copy-and-paste error in JDK-8303852. Adding the missing opening brace would fix this build failure.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315073: Zero build on macOS fails after JDK-8303852 (Bug - P4)

Reviewers

• Jie Fu (@DamonFool - Reviewer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15443/head:pull/15443
$ git checkout pull/15443

Update a local copy of the PR:
$ git checkout pull/15443
$ git pull https://git.openjdk.org/jdk.git pull/15443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15443

View PR using the GUI difftool:
$ git pr show -t 15443

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15443.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back haosun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shqking The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f2a80a5a)

[DamonFool]

LGTM assuming that you have verified both the release and debug zero builds on MacOS.
Thanks.

[openjdk]

@shqking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315073: Zero build on macOS fails after JDK-8303852

Reviewed-by: jiefu, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
• 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
• cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
• 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
• 0901d75: 8314762: Make {@Incubating} conventional

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shqking]

LGTM assuming that you have verified both the release and debug zero builds on MacOS. Thanks.

Thanks for your reminding. Yes, both release and debug zero builds on macOS can pass with this patch.

[RealFYang]

That looks obvious.

[shqking]

Thanks for your reviews.
/integrate

[openjdk]

Going to push as commit 25f5df2.
Since your change was applied there have been 18 commits pushed to the master branch:

• a03954e: 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests
• e5ea9aa: 8312570: [TESTBUG] Jtreg compiler/loopopts/superword/TestDependencyOffsets.java fails on 512-bit SVE
• 1cb2cc6: 8308464: Shared array class should not always be loaded in boot loader
• 69d1feb: 8315060: Out of tree incremental build fails with ccache
• 8e2a533: 8315137: Add explicit override RecordComponentElement.asType()
• b4b2fec: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
• 31e2681: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• 21916f3: 8139208: [macosx] Issue with setExtendedState of JFrame
• 99ea8bf: 8315062: [GHA] get-bootjdk action should return the abolute path
• acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
• ... and 8 more: https://git.openjdk.org/jdk/compare/12de9b0225363377e9a76729b11698221d4f29f2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shqking Pushed as commit 25f5df2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.