8315413: Remove special filtering of Continuation.yield0 in StackWalker

[mlchung]

Loom added a special filtering of Continuation.yield0 in stack walker. After the initial implementation, JDK-8304919 marks the yielding and entering methods with @Hidden and hidden frames are filtered by stack walker by default. With @Hidden the special filtering should not be needed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315413: Remove special filtering of Continuation.yield0 in StackWalker (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15498/head:pull/15498
$ git checkout pull/15498

Update a local copy of the PR:
$ git checkout pull/15498
$ git pull https://git.openjdk.org/jdk.git pull/15498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15498

View PR using the GUI difftool:
$ git pr show -t 15498

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15498.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f5deb5c5)

[AlanBateman]

If tests are passing then this should be okay.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315413: Remove special filtering of Continuation.yield0 in StackWalker

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 218829e: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
• 3c8a667: 8314611: Provide more explicative error message parsing Currencies
• df5e6e5: 8315248: AssertionError in Name.compareTo

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlchung]

/integrate

[openjdk]

Going to push as commit c8acab1.
Since your change was applied there have been 11 commits pushed to the master branch:

• ea5aa61: 8315383: jlink SystemModulesPlugin incorrectly parses the options
• 29ff1e4: 8315445: 8314748 causes crashes in x64 builds
• 145d8bc: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs
• 486fa08: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• b0353ad: 8315242: G1: Fix -Wconversion warnings around GCDrainStackTargetSize
• b594f01: 8314748: 1-10% regressions on Crypto micros
• 39f1813: 8315318: Typo in comment on sun.nio.ch.Net.unblock4
• 47aa6f3: 8315219: G1: Improve allocator pathological case where it keeps doing direct allocations instead of retiring a PLAB
• 218829e: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
• 3c8a667: 8314611: Provide more explicative error message parsing Currencies
• ... and 1 more: https://git.openjdk.org/jdk/compare/3eac8905aee6edecbebcc12a41300d3ce176fbff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit c8acab1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.