New issue

Jump to bottom

8315594: Open source few headless Swing misc tests #15577

Closed

prsadhuk wants to merge 2 commits into openjdk:master from prsadhuk:JDK-8315594

+256 −0

Contributor

prsadhuk commented Sep 6, 2023 •

edited by openjdk bot

Loading

Few closed swing tests are open sourced

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8315594: Open source few headless Swing misc tests (Bug - P4)

Reviewers

Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15577/head:pull/15577
$ git checkout pull/15577

Update a local copy of the PR:
$ git checkout pull/15577
$ git pull https://git.openjdk.org/jdk.git pull/15577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15577

View PR using the GUI difftool:
$ git pr show -t 15577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15577.diff

Webrev

Link to Webrev Comment


          8315594:Open source few headless Swing misc tests

51e9731

bridgekeeper bot commented Sep 6, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk bot commented Sep 6, 2023

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk bot added the client label

prsadhuk changed the title ~~8315594:Open source few headless Swing misc tests~~ 8315594: Open source few headless Swing misc tests

openjdk bot added the rfr label

mlbridge bot commented Sep 6, 2023 •

edited

Loading

Webrevs

01: Full - Incremental (2a309750)
00: Full (51e9731c)

turbanoff reviewed

View reviewed changes

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4267840.java Outdated

+                              FileOutputStream out = new FileOutputStream(file);
+                              kit.write(out, textpane.getDocument(), 0,
+                                        textpane.getDocument().getLength());
+                              out.close ();

Member

turbanoff Sep 6, 2023

Suggested change

      
                            out.close ();
          
                            out.close();

turbanoff reviewed

View reviewed changes

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4267840.java Outdated

+                              out.close ();
+                          } catch (Exception e) {}
+                          try {
+                              if (file.length() < 6 ) {  // simply can't be

Member

turbanoff Sep 6, 2023

Suggested change

      
                            if (file.length() < 6 ) {  // simply can't be
          
                            if (file.length() < 6) {  // simply can't be

turbanoff reviewed

View reviewed changes

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4267840.java Outdated

+              public class bug4267840 {
+                  public static void main(String[] args) throws Exception {
+                      SwingUtilities.invokeAndWait(() -> {
+                          final JTextPane textpane = new JTextPane ();

Member

turbanoff Sep 6, 2023

Suggested change

      
                        final JTextPane textpane = new JTextPane ();
          
                        final JTextPane textpane = new JTextPane();

turbanoff reviewed

View reviewed changes

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4267840.java Outdated

+                      SwingUtilities.invokeAndWait(() -> {
+                          final JTextPane textpane = new JTextPane ();
+                          textpane.setContentType ("text/html");
+                          final EditorKit kit = textpane.getEditorKit ();

Member

turbanoff Sep 6, 2023

Suggested change

      
                        final EditorKit kit = textpane.getEditorKit ();
          
                        final EditorKit kit = textpane.getEditorKit();

turbanoff reviewed

View reviewed changes

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4267840.java Outdated

+                  public static void main(String[] args) throws Exception {
+                      SwingUtilities.invokeAndWait(() -> {
+                          final JTextPane textpane = new JTextPane ();
+                          textpane.setContentType ("text/html");

Member

turbanoff Sep 6, 2023

Suggested change

      
                        textpane.setContentType ("text/html");
          
                        textpane.setContentType("text/html");


          Spacing issue

2a30975

azvegint approved these changes

View reviewed changes

openjdk bot commented Sep 7, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315594: Open source few headless Swing misc tests

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

81f8c57: 8314632: Intra-case dominance check fails in the presence of a guard
b408a82: 8314260: Unable to load system libraries on Windows when using a SecurityManager
726c9c9: 8315735: VerifyError when switch statement used with synchronized block
fd6442c: 8315602: Open source swing security manager test
e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
b05198a: 8315600: Open source few more headless Swing misc tests
4127fbb: 8315606: Open source few swing text/html tests
... and 69 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk bot added the ready label

Contributor Author

prsadhuk commented Sep 8, 2023

/integrate

openjdk bot commented Sep 8, 2023

Going to push as commit 806ef08.
Since your change was applied there have been 92 commits pushed to the master branch:

4b43c25: 8310929: Optimization for Integer.toString
111ecdb: 8268829: Provide an optimized way to walk the stack with Class object only
716201c: 8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs
4c6d7fc: 8315795: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java fails after JDK-8305507
7e7ab6e: 8315877: ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64
0c865a7: 8315637: JDK-8314249 broke libgraal
683672c: 8292692: Move MethodCounters inline functions out of method.hpp
9bf3dee: 8314831: NMT tests ignore vm flags
b74805d: 8315863: [GHA] Update checkout action to use v4
1cae0f5: 8315220: Event NativeLibraryLoad breaks invariant by taking a stacktrace when thread is in state _thread_in_native
... and 82 more: https://git.openjdk.org/jdk/compare/145d8bc1a3ef4f4fe0c10385be111838e7ed9250...master

Your commit was automatically rebased without conflicts.

openjdk bot added the integrated label

openjdk bot closed this

openjdk bot removed ready rfr labels

openjdk bot commented Sep 8, 2023

@prsadhuk Pushed as commit 806ef08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

prsadhuk deleted the JDK-8315594 branch

September 8, 2023 03:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client integrated