8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate

[RealLucy]

…missing aggregate

If jcmd users want to print statistical data about a specific property of the code heap (instead of requesting "all"), they first have to aggregate such data. If this step was forgotten, the requested function just returns. This should be improved.

------ Output before enhancement --------

> bin/jcmd <pid> Compiler.CodeHeap_Analytics FreeSpace 
<pid>: 

__ CodeHeapStateAnalytics lock wait took 0.000 seconds _________ 

__ CodeHeapStateAnalytics total duration 0.000 seconds _________ 

------ Output after enhancement --------

> bin/jcmd <pid> Compiler.CodeHeap_Analytics FreeSpace 
<pid>: 

__ CodeHeapStateAnalytics lock wait took 0.000 seconds _________ 

No aggregated data available for heap CodeHeap. Run function aggregate first. 

__ CodeHeapStateAnalytics total duration 0.000 seconds _________ 

Comments and reviews are very much appreciated.
Tests (GHA and SAP-internal test suite) pending.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15900/head:pull/15900
$ git checkout pull/15900

Update a local copy of the PR:
$ git checkout pull/15900
$ git pull https://git.openjdk.org/jdk.git pull/15900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15900

View PR using the GUI difftool:
$ git pr show -t 15900

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15900.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealLucy The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5e77d5bd)

[vnkozlov]

Looks good.

[openjdk]

@RealLucy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate

Reviewed-by: kvn, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• 77fac0f: 8316906: Clarify TLABWasteTargetPercent flag
• 2d154fc: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
• 42924ed: 8316946: jtreg failure handler pages are mislabelling the jcmd/thread/dump_to_file results.
• 384d2ea: 8316125: Windows call_stub unnecessarily saves xmm16-31 when UseAVX>=3
• 84390dd: 8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently
• 52073b2: 8316994: Avoid modifying ClassLoader and Module objects during -Xshare:dump
• 83c0e45: 8306630: Bump minimum boot jdk to JDK 21
• d3a79b5: 8316371: Open some swing tests 6
• 750da00: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
• b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
• ... and 38 more: https://git.openjdk.org/jdk/compare/0f0c5b2d71e6dec442a5105ba305043cb59b99fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealLucy]

Thank you, Vladimir, for the review!

[TheRealMDoerr]

LGTM.

[RealLucy]

Thank you, Martin!
/integrate

[openjdk]

Going to push as commit 1230aed.
Since your change was applied there have been 52 commits pushed to the master branch:

• d0c1444: 8316957: Serial: Change GenCollectedHeap to SerialHeap inside gc/serial folder
• bc5a39b: 8317144: Exclude sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java on Linux ppc64le
• 3481ecb: 8316159: Update BoxLayout sample image for crisper edges
• 7981251: 8316970: Add internal annotation to mark restricted methods
• 77fac0f: 8316906: Clarify TLABWasteTargetPercent flag
• 2d154fc: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
• 42924ed: 8316946: jtreg failure handler pages are mislabelling the jcmd/thread/dump_to_file results.
• 384d2ea: 8316125: Windows call_stub unnecessarily saves xmm16-31 when UseAVX>=3
• 84390dd: 8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently
• 52073b2: 8316994: Avoid modifying ClassLoader and Module objects during -Xshare:dump
• ... and 42 more: https://git.openjdk.org/jdk/compare/0f0c5b2d71e6dec442a5105ba305043cb59b99fc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealLucy Pushed as commit 1230aed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.