JDK-8316894: make test TEST="jtreg:test/jdk/..." fails on AIX

[MBaesken]

Running jtreg tests with make test, for example
make test TEST="jtreg:test/jdk/java/util/prefs" fails currently on AIX without setting the number of JOBS manually.
We get this error message:
Error: Bad use of -concurrency

Log of cmdargs shows :
-vmoption:-Xmx768m
-agentvm
-verbose:fail,error,summary
-retain:fail,error
-concurrency:7.000000
....

So currently a float is used for the concurrency value, seems this is not supported.
Reason is an old gawk printing float values instead of the needed ints, so better print ints in the makefile by using %d .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316894: make test TEST="jtreg:test/jdk/..." fails on AIX (Bug - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15941/head:pull/15941
$ git checkout pull/15941

Update a local copy of the PR:
$ git checkout pull/15941
$ git pull https://git.openjdk.org/jdk.git pull/15941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15941

View PR using the GUI difftool:
$ git pr show -t 15941

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15941.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8319f695)
• 00: Full (32531634)

[magicus]

Looks good. Have you verified that this works with nawk as well as old gawk versions?

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316894: make test TEST="jtreg:test/jdk/..." fails on AIX

Reviewed-by: ihse, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• fc98998: 8316580: HttpClient with StructuredTaskScope does not close when a task fails
• 065203d: 8313631: SA: stack trace printed using "where" command does not show class name
• 0c55887: 8309599: WeakHandle and OopHandle release should clear obj pointer
• 1230aed: 8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate
• d0c1444: 8316957: Serial: Change GenCollectedHeap to SerialHeap inside gc/serial folder
• bc5a39b: 8317144: Exclude sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java on Linux ppc64le
• 3481ecb: 8316159: Update BoxLayout sample image for crisper edges
• 7981251: 8316970: Add internal annotation to mark restricted methods
• 77fac0f: 8316906: Clarify TLABWasteTargetPercent flag
• 2d154fc: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
• ... and 16 more: https://git.openjdk.org/jdk/compare/fee9d3362c76a046bb5160b90536545e7e9a5ce9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

Looks good. Have you verified that this works with nawk as well as old gawk versions?

On AIX I have both nawk and gawk on the machine and both work with the change.
On Linux I have just gawk (more recent one) and this works too.

[erikj79]

As was pointed out in the bug, this changes the meaning of the expression to always round down rather than rounding to nearest integer, which was my intention when I originally added this logic. For higher cpu counts, this doesn't matter much, but for smaller systems, it can make a big difference if we run with 1 or 2 jobs.

To work around this, perhaps add 0.5 to c before converting to int?

[MBaesken]

To work around this, perhaps add 0.5 to c before converting to int?

Hi Erik, sure we can do so , I adjusted the change.

[MBaesken]

Hi Magnus and Erik, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 29348b3.
Since your change was applied there have been 27 commits pushed to the master branch:

• 3f19df6: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
• fc98998: 8316580: HttpClient with StructuredTaskScope does not close when a task fails
• 065203d: 8313631: SA: stack trace printed using "where" command does not show class name
• 0c55887: 8309599: WeakHandle and OopHandle release should clear obj pointer
• 1230aed: 8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate
• d0c1444: 8316957: Serial: Change GenCollectedHeap to SerialHeap inside gc/serial folder
• bc5a39b: 8317144: Exclude sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java on Linux ppc64le
• 3481ecb: 8316159: Update BoxLayout sample image for crisper edges
• 7981251: 8316970: Add internal annotation to mark restricted methods
• 77fac0f: 8316906: Clarify TLABWasteTargetPercent flag
• ... and 17 more: https://git.openjdk.org/jdk/compare/fee9d3362c76a046bb5160b90536545e7e9a5ce9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 29348b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.