8301327: convert assert to guarantee in Handle_IDiv_Exception

[afshin-zafari]

The assert usages are replaced with guarantee.

Tested tier1-4, windows-x64 and windows-x64-debug.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301327: convert assert to guarantee in Handle_IDiv_Exception (Enhancement - P4)

Reviewers

• Doug Simon (@dougxc - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15945/head:pull/15945
$ git checkout pull/15945

Update a local copy of the PR:
$ git checkout pull/15945
$ git pull https://git.openjdk.org/jdk.git pull/15945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15945

View PR using the GUI difftool:
$ git pr show -t 15945

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15945.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e3893ee2)
• 00: Full (63d9c5a7)

[dougxc]

Thanks for doing this. Can you please enhance the error message of each guarantee to include the unexpected/problematic value(s).

[afshin-zafari]

Thanks for doing this. Can you please enhance the error message of each guarantee to include the unexpected/problematic value(s).

The expected and actual values are now printed in the guarantee message.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301327: convert assert to guarantee in Handle_IDiv_Exception

Reviewed-by: dnsimon, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• 355811a: 8316559: Refactor some util/Calendar tests to JUnit
• ecb5e8a: 8317264: Pattern.Bound has static fields that should be static final.
• f2c221d: 8317119: Remove unused imports in the java.util.stream package
• 09dad0e: 8313810: BoxLayout uses

  instead of list for layout options

• 73a47f0: 4622866: javax.swing.text.Document.remove(int, int) has a misleading picture
• cfcbfc6: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
• ca5eee2: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless
• 060db1b: 8315031: YoungPLABSize and OldPLABSize not aligned by ObjectAlignmentInBytes
• 3481a48: 8316974: ListFormat creation is unsuccessful for some of the supported Locales
• 29348b3: 8316894: make test TEST="jtreg:test/jdk/..." fails on AIX
• ... and 25 more: https://git.openjdk.org/jdk/compare/45a145e5bc3d3216bb03379896f66a3b719a06dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Seems reasonable.

Thanks

[afshin-zafari]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit c45308a.
Since your change was applied there have been 37 commits pushed to the master branch:

• bd7bb67: 8317257: RISC-V: llvm build broken
• 0259da9: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
• 355811a: 8316559: Refactor some util/Calendar tests to JUnit
• ecb5e8a: 8317264: Pattern.Bound has static fields that should be static final.
• f2c221d: 8317119: Remove unused imports in the java.util.stream package
• 09dad0e: 8313810: BoxLayout uses

  instead of list for layout options

• 73a47f0: 4622866: javax.swing.text.Document.remove(int, int) has a misleading picture
• cfcbfc6: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
• ca5eee2: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless
• 060db1b: 8315031: YoungPLABSize and OldPLABSize not aligned by ObjectAlignmentInBytes
• ... and 27 more: https://git.openjdk.org/jdk/compare/45a145e5bc3d3216bb03379896f66a3b719a06dc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@afshin-zafari Pushed as commit c45308a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.