Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317675: Serial: Move gc/shared/generation to serial folder #16072

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 6, 2023

Simple moving files/renamings.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317675: Serial: Move gc/shared/generation to serial folder (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16072/head:pull/16072
$ git checkout pull/16072

Update a local copy of the PR:
$ git checkout pull/16072
$ git pull https://git.openjdk.org/jdk.git pull/16072/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16072

View PR using the GUI difftool:
$ git pr show -t 16072

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16072.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8317675 8317675: Serial: Move gc/shared/generation to serial folder Oct 6, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 6, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2023

Webrevs

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Oct 7, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317675: Serial: Move gc/shared/generation to serial folder

Reviewed-by: mli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 731fb4e: 8317797: G1: Remove unimplemented predict_will_fit
  • 7976151: 8313438: [s390x] build broken after JDK-8301996
  • ca96fd3: 8317839: Exclude java/nio/channels/Channels/SocketChannelStreams.java on AIX
  • a9b41da: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 0fd8071: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic"
  • 1161e3d: 8317803: Exclude java/net/Socket/asyncClose/Race.java on AIX
  • e55c482: 8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX
  • 84b7cc1: 8317761: Combine two versions of print_statistics() in java.cpp
  • 3aa4cba: 8316975: Memory leak in MTLSurfaceData
  • 54861df: 8317802: jmh tests fail with Unable to find the resource: /META-INF/BenchmarkList after JDK-8306819
  • ... and 32 more: https://git.openjdk.org/jdk/compare/b3cc0c84316dd59f406a6fa23fcaf3d029910843...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

Going to push as commit 8a9c4d5.
Since your change was applied there have been 43 commits pushed to the master branch:

  • bcafec5: 8316958: Add test for unstructured locking
  • 731fb4e: 8317797: G1: Remove unimplemented predict_will_fit
  • 7976151: 8313438: [s390x] build broken after JDK-8301996
  • ca96fd3: 8317839: Exclude java/nio/channels/Channels/SocketChannelStreams.java on AIX
  • a9b41da: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 0fd8071: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic"
  • 1161e3d: 8317803: Exclude java/net/Socket/asyncClose/Race.java on AIX
  • e55c482: 8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX
  • 84b7cc1: 8317761: Combine two versions of print_statistics() in java.cpp
  • 3aa4cba: 8316975: Memory leak in MTLSurfaceData
  • ... and 33 more: https://git.openjdk.org/jdk/compare/b3cc0c84316dd59f406a6fa23fcaf3d029910843...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2023
@openjdk openjdk bot closed this Oct 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@albertnetymk Pushed as commit 8a9c4d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-generation branch October 11, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants