Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268916: Tests for AffirmTrust roots #16190

Closed
wants to merge 1 commit into from
Closed

8268916: Tests for AffirmTrust roots #16190

wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Oct 13, 2023

Test is updated to include interoperability testing for 4 AffirmTrust root CAs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268916: Tests for AffirmTrust roots (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16190/head:pull/16190
$ git checkout pull/16190

Update a local copy of the PR:
$ git checkout pull/16190
$ git pull https://git.openjdk.org/jdk.git pull/16190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16190

View PR using the GUI difftool:
$ git pr show -t 16190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16190.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268916: Tests for AffirmTrust roots

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 668d4b0: 8318154: Improve stability of WheelModifier.java test
  • a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • a27fc7e: 8317994: Serial: Use SerialHeap in generation
  • 37eb986: 8154846: SwingNode does not resize when content size constraints are changed
  • 37aed6f: 8315362: NMT: summary diff reports threads count incorrectly
  • 1e930db: 8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification
  • 0275efa: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 77d40ce: 8318085: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-aarch64
  • 4ea1b99: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"
  • 01ea1ef: 8305971: NPE in JavacProcessingEnvironment for missing enum constructor body
  • ... and 9 more: https://git.openjdk.org/jdk/compare/605c9767291ddf1c409c3e805ffb3182899d06c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 16, 2023
@rhalade
Copy link
Member Author

rhalade commented Oct 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

Going to push as commit 8c1bb2b.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 2d38495: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame
  • 0d09168: 8312527: (ch) Re-examine use of sun.nio.ch.Invoker.myGroupAndInvokeCount
  • 1a7fd5d: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS
  • eb7d972: 8308659: Use CSS scroll-margin instead of flexbox layout in API documentation
  • 7028fb9: 8317975: [JVMCI] assert(pointee != nullptr) failed: invariant
  • 36993ae: 8316918: Optimize conversions duplicated across phi nodes
  • 668d4b0: 8318154: Improve stability of WheelModifier.java test
  • a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • a27fc7e: 8317994: Serial: Use SerialHeap in generation
  • 37eb986: 8154846: SwingNode does not resize when content size constraints are changed
  • ... and 15 more: https://git.openjdk.org/jdk/compare/605c9767291ddf1c409c3e805ffb3182899d06c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2023
@openjdk openjdk bot closed this Oct 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2023
@rhalade rhalade deleted the 8268916-affirmtrust branch October 16, 2023 16:26
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@rhalade Pushed as commit 8c1bb2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

2 participants