8318102: macos10.14 check in CSystemColors can be removed.

[prsadhuk]

Since JDK-8317970 in integrated to make macOS 11 the minimum version to build jdk, the 10.14 check added in JDK-8284166 is not needed and can be removed..

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318102: macos10.14 check in CSystemColors can be removed. (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16198/head:pull/16198
$ git checkout pull/16198

Update a local copy of the PR:
$ git checkout pull/16198
$ git pull https://git.openjdk.org/jdk.git pull/16198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16198

View PR using the GUI difftool:
$ git pr show -t 16198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16198.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (86b5e713)

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318102: macos10.14 check in CSystemColors can be removed.

Reviewed-by: prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 741ae06: 8313613: Use JUnit in langtools/lib tests
• 8c1bb2b: 8268916: Tests for AffirmTrust roots
• 2d38495: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame
• 0d09168: 8312527: (ch) Re-examine use of sun.nio.ch.Invoker.myGroupAndInvokeCount
• 1a7fd5d: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS
• eb7d972: 8308659: Use CSS scroll-margin instead of flexbox layout in API documentation
• 7028fb9: 8317975: [JVMCI] assert(pointee != nullptr) failed: invariant
• 36993ae: 8316918: Optimize conversions duplicated across phi nodes
• 668d4b0: 8318154: Improve stability of WheelModifier.java test
• a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
• ... and 6 more: https://git.openjdk.org/jdk/compare/4ea1b99c1a6efe144af381ea538f93718e9baf74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit d7205e6.
Since your change was applied there have been 163 commits pushed to the master branch:

• 5ce718e: 8318100: Remove redundant check for Metal support
• f1dfdc1: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild
• 9c819fd: 8318051: Duration.between uses exceptions for control flow
• 1ddf826: 8316964: Security tools should not call System.exit
• 1f2a80b: 8318306: java/util/Arrays/Sorting.java fails with "Array is not sorted at 8228-th position: 8251.0 and 8153.0"
• 1165037: 8318569: Add getter methods for Locale and Patterns in ListFormat
• 6f35274: 8318702: G1: Fix nonstandard indentation in g1HeapTransition.cpp
• e272098: 8318160: javac does not reject private method reference with type-variable receiver
• 54c613a: 8318693: Fix rendering for code blocks nested under list items in building.md
• e67550c: 8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0
• ... and 153 more: https://git.openjdk.org/jdk/compare/4ea1b99c1a6efe144af381ea538f93718e9baf74...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit d7205e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.