Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318104: macOS 10.13 check in TabButtonAccessibility.m can be removed #16218

Closed
wants to merge 1 commit into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Oct 17, 2023

Since JDK-8317970 is integrated to make macOS 11 the minimum version to build jdk, the 10.13 check is not needed and can be removed from TabButtonAccessibility.m file.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318104: macOS 10.13 check in TabButtonAccessibility.m can be removed (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16218/head:pull/16218
$ git checkout pull/16218

Update a local copy of the PR:
$ git checkout pull/16218
$ git pull https://git.openjdk.org/jdk.git pull/16218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16218

View PR using the GUI difftool:
$ git pr show -t 16218

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16218.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 17, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318104: macOS 10.13 check in TabButtonAccessibility.m can be removed

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • e25a49a: 8318471: ProblemList compiler/sharedstubs/SharedTrampolineTest.java
  • ce8ebeb: 8317979: Use TZ database style abbreviations in the CLDR locale provider
  • ab13568: 8318029: Minor improvement to logging output in container at-requires
  • 278de7a: 8318458: Update javac and java manpages with restricted method options
  • 6fc3514: 8318363: Foreign benchmarks fail to build on some platforms
  • 31ef400: 8318183: C2: VM may crash after hitting node limit
  • 4e77b3c: 8315974: Make fields final in 'com.sun.crypto.provider' package
  • 8dd8096: 8317886: Add @sealedGraph to ByteBuffer
  • 9843c97: 8318365: Test runtime/cds/appcds/sharedStrings/InternSharedString.java fails after JDK-8311538
  • 7c80cb2: 8309966: Enhanced TLS connections
  • ... and 34 more: https://git.openjdk.org/jdk/compare/7b3917265dec7e975c0abb31b4069ac12f43f575...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 17, 2023
@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

Going to push as commit 24bc5bd.
Since your change was applied there have been 44 commits pushed to the master branch:

  • e25a49a: 8318471: ProblemList compiler/sharedstubs/SharedTrampolineTest.java
  • ce8ebeb: 8317979: Use TZ database style abbreviations in the CLDR locale provider
  • ab13568: 8318029: Minor improvement to logging output in container at-requires
  • 278de7a: 8318458: Update javac and java manpages with restricted method options
  • 6fc3514: 8318363: Foreign benchmarks fail to build on some platforms
  • 31ef400: 8318183: C2: VM may crash after hitting node limit
  • 4e77b3c: 8315974: Make fields final in 'com.sun.crypto.provider' package
  • 8dd8096: 8317886: Add @sealedGraph to ByteBuffer
  • 9843c97: 8318365: Test runtime/cds/appcds/sharedStrings/InternSharedString.java fails after JDK-8311538
  • 7c80cb2: 8309966: Enhanced TLS connections
  • ... and 34 more: https://git.openjdk.org/jdk/compare/7b3917265dec7e975c0abb31b4069ac12f43f575...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2023
@openjdk openjdk bot closed this Oct 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@kumarabhi006 Pushed as commit 24bc5bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants