-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316046: x64 platforms unecessarily save xmm16-31 when UseAVX >= 3 #16307
Conversation
👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into |
@JornVernee The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@JornVernee This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d1077d6.
Your commit was automatically rebased without conflicts. |
@JornVernee Pushed as commit d1077d6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
See JBS issue. We don't need to save xmm16+ on x64 platforms (which are currently saved in FFM upcall stubs). This is achieved simply by adding these registers to the volatile register lists of both ABIs.
Related: #15688
Testing:
jdk_foreign
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16307/head:pull/16307
$ git checkout pull/16307
Update a local copy of the PR:
$ git checkout pull/16307
$ git pull https://git.openjdk.org/jdk.git pull/16307/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16307
View PR using the GUI difftool:
$ git pr show -t 16307
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16307.diff
Webrev
Link to Webrev Comment