Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8318908: Parallel: Remove ExtendedCardValue #16380

Closed
wants to merge 1 commit into from
Closed

8318908: Parallel: Remove ExtendedCardValue #16380

wants to merge 1 commit into from
+2 −37

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 26, 2023 •
edited by openjdk bot
Loading

Simple removing some dead code; after this, a card is either clean or dirty.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318908: Parallel: Remove ExtendedCardValue (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16380/head:pull/16380
$ git checkout pull/16380

Update a local copy of the PR:
$ git checkout pull/16380
$ git pull https://git.openjdk.org/jdk.git pull/16380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16380

View PR using the GUI difftool:
$ git pr show -t 16380

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16380.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8318908 8318908: Parallel: Remove ExtendedCardValue Oct 26, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 26, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2023

Webrevs

tschatzl
tschatzl approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk
Copy link

openjdk bot commented Oct 30, 2023 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318908: Parallel: Remove ExtendedCardValue

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

  • e05cafd: 8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads
  • d3c3f0e: 8317951: Refactor loading of zip library to help resolve JDK-8315220
  • 576c9bc: 8318492: Http2ClientImpl should attempt to close and remove connection in stop()
  • 5411ad2: 8319106: Remove unimplemented TaskTerminator::do_delay_step
  • 75ce02f: 8318951: Additional negative value check in JPEG decoding
  • 328b381: 8009550: PlatformPCSC should load versioned so
  • d051f22: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
  • 1ca2cfa: 8310933: Copying from runtime image to application image should not follow symlinks
  • d3534b0: 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter
  • 864a876: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
  • ... and 35 more: https://git.openjdk.org/jdk/compare/ec1bf23d012f007c126cb472fcff146cf7f41b1a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2023
kstefanj
kstefanj approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment/question? Feel free to integrate if you don't see a need to change the name.

src/hotspot/share/gc/parallel/psCardTable.cpp
@@ -389,20 +389,7 @@ void PSCardTable::verify_all_young_refs_imprecise() {

bool PSCardTable::addr_is_marked_imprecise(void *addr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to keep this name when we don't have the "precise" counterpart and what all it does is checking if the card is dirty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed odd. I will rename it to sth else in a follow-up PR. Even "marked" is weird here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, my first thought was addr_is_dirty(void* addr).

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 31, 2023

Going to push as commit f4c5db9.
Since your change was applied there have been 48 commits pushed to the master branch:

  • 7452d50: 8318940: [JVMCI] do not set HotSpotNmethod oop for a default HotSpotNmethod
  • 3e39d7b: 8319136: Skip pkcs11 tests on linux-aarch64
  • ee6f25b: 8319120: Unbound ScopedValue.get() throws the wrong exception
  • e05cafd: 8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads
  • d3c3f0e: 8317951: Refactor loading of zip library to help resolve JDK-8315220
  • 576c9bc: 8318492: Http2ClientImpl should attempt to close and remove connection in stop()
  • 5411ad2: 8319106: Remove unimplemented TaskTerminator::do_delay_step
  • 75ce02f: 8318951: Additional negative value check in JPEG decoding
  • 328b381: 8009550: PlatformPCSC should load versioned so
  • d051f22: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
  • ... and 38 more: https://git.openjdk.org/jdk/compare/ec1bf23d012f007c126cb472fcff146cf7f41b1a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2023
@openjdk openjdk bot closed this Oct 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

@albertnetymk Pushed as commit f4c5db9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the pgc-trim-card-enum branch October 31, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstefanj kstefanj

@tschatzl tschatzl

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertnetymk @kstefanj @tschatzl