Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319620: Parallel: Remove unused PSPromotionManager::*_is_full getters and setters #16539

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Nov 7, 2023

Hello,

please review this trivial removal of some unused member functions in PSPromotionManager.

Testing: local compilation

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319620: Parallel: Remove unused PSPromotionManager::*_is_full getters and setters (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16539/head:pull/16539
$ git checkout pull/16539

Update a local copy of the PR:
$ git checkout pull/16539
$ git pull https://git.openjdk.org/jdk.git pull/16539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16539

View PR using the GUI difftool:
$ git pr show -t 16539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16539.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@tschatzl tschatzl changed the title 8319620-remove-is-full-getters 8319620 Nov 7, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8319620 8319620: Parallel: Remove unused PSPromotionManager::*_is_full getters and setters Nov 7, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 7, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2023

Webrevs

Copy link
Member

@albertnetymk albertnetymk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319620: Parallel: Remove unused PSPromotionManager::*_is_full getters and setters

Reviewed-by: ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • ac0ee20: 8319613: Complier error in benchmark TestLoadSegmentVarious
  • a7c0190: 8319238: JMX ThreadPoolAccTest.java is too verbose and should fail before timeout
  • 9ac6ac8: 8319559: [JVMCI] ensureLinked must be able to call Java
  • 1c0e7b7: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations
  • 74f1889: 8318678: Vector access on heap MemorySegments only works for byte[]
  • e1cae72: 8319197: Exclude hb-subset and hb-style from compilation
  • 419ed90: 8319450: New methods java.net.InetXAddress.ofLiteral() miss @SInCE tag
  • 439ed04: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning
  • e4803e0: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • cdf3373: 8319316: Clarify text around which layouts a linker supports
  • ... and 19 more: https://git.openjdk.org/jdk/compare/ec79ab4b3cd89c2c0a9c8550cd62433bd6d45266...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2023
@tschatzl
Copy link
Contributor Author

tschatzl commented Nov 7, 2023

Thanks @albertnetymk for your review
/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit 85e4cde.
Since your change was applied there have been 32 commits pushed to the master branch:

  • d22e368: 8319462: Signature.ClassTypeSig::classDesc() incorrect for inner class types
  • 541ff71: 8318144: Match on enum constants with body compiles but fails with MatchException
  • 42f43c5: 8319563: Reformat code in the FFM API
  • ac0ee20: 8319613: Complier error in benchmark TestLoadSegmentVarious
  • a7c0190: 8319238: JMX ThreadPoolAccTest.java is too verbose and should fail before timeout
  • 9ac6ac8: 8319559: [JVMCI] ensureLinked must be able to call Java
  • 1c0e7b7: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations
  • 74f1889: 8318678: Vector access on heap MemorySegments only works for byte[]
  • e1cae72: 8319197: Exclude hb-subset and hb-style from compilation
  • 419ed90: 8319450: New methods java.net.InetXAddress.ofLiteral() miss @SInCE tag
  • ... and 22 more: https://git.openjdk.org/jdk/compare/ec79ab4b3cd89c2c0a9c8550cd62433bd6d45266...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@tschatzl Pushed as commit 85e4cde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8319620-remove-is-full-getters branch January 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants