Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305839: Add application/sql MIME type for SQL file extension #16563

Closed
wants to merge 4 commits into from

Conversation

IzumiDIA
Copy link

@IzumiDIA IzumiDIA commented Nov 8, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with the updated jcheck configuration)

Issue

  • JDK-8305839: Add application/sql MIME type for SQL file extension (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16563/head:pull/16563
$ git checkout pull/16563

Update a local copy of the PR:
$ git checkout pull/16563
$ git pull https://git.openjdk.org/jdk.git pull/16563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16563

View PR using the GUI difftool:
$ git pr show -t 16563

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16563.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

👋 Welcome back IzumiDIA! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@IzumiDIA The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added net net-dev@openjdk.org rfr Pull request is ready for review labels Nov 8, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2023

Webrevs

@IzumiDIA IzumiDIA marked this pull request as draft November 16, 2023 14:33
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 16, 2023
@IzumiDIA IzumiDIA marked this pull request as ready for review November 16, 2023 15:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 16, 2023
@RogerRiggs
Copy link
Contributor

This looks pretty straight-forward, a review by a member of the network group would be useful.

@dfuch
Copy link
Member

dfuch commented Nov 16, 2023

Have you run tier2 tests? We had random test failures in the past when modifying this table: on some systems some of the tests rely on the platform notion of mime-types, and where an extension can legitimately be mapped to different mime types some of the tests will fail.

@IzumiDIA IzumiDIA closed this Nov 16, 2023
@IzumiDIA IzumiDIA reopened this Nov 16, 2023
@IzumiDIA
Copy link
Author

IzumiDIA commented Nov 16, 2023

Have you run tier2 tests? We had random test failures in the past when modifying this table: on some systems some of the tests rely on the platform notion of mime-types, and where an extension can legitimately be mapped to different mime types some of the tests will fail.

This is my first time participating in open source contribution. Sorry I don't know how to run tier2 tests. But The Internet Assigned Numbers Authority (IANA) registered the ".sql" file extension 10 years ago. That is, ".sql" can uniquely identify Structured Query Language files. I'm referring to https://www.iana.org/assignments/media-types/application/sql.

@RogerRiggs
Copy link
Contributor

Read through /doc/testing.md.

You should be able to build and test something like:
make test TEST=tier2

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@IzumiDIA this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout patch-1
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Dec 7, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

@IzumiDIA This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

@IzumiDIA This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict Pull request has merge conflict with target branch net net-dev@openjdk.org rfr Pull request is ready for review
3 participants