New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8305839: Add application/sql MIME type for SQL file extension #16563
Conversation
👋 Welcome back IzumiDIA! A progress list of the required criteria for merging this PR into |
Webrevs
|
This looks pretty straight-forward, a review by a member of the network group would be useful. |
Have you run tier2 tests? We had random test failures in the past when modifying this table: on some systems some of the tests rely on the platform notion of mime-types, and where an extension can legitimately be mapped to different mime types some of the tests will fail. |
This is my first time participating in open source contribution. Sorry I don't know how to run tier2 tests. But The Internet Assigned Numbers Authority (IANA) registered the ".sql" file extension 10 years ago. That is, ".sql" can uniquely identify Structured Query Language files. I'm referring to https://www.iana.org/assignments/media-types/application/sql. |
Read through /doc/testing.md. You should be able to build and test something like: |
@IzumiDIA this pull request can not be integrated into git checkout patch-1
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@IzumiDIA This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@IzumiDIA This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16563/head:pull/16563
$ git checkout pull/16563
Update a local copy of the PR:
$ git checkout pull/16563
$ git pull https://git.openjdk.org/jdk.git pull/16563/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16563
View PR using the GUI difftool:
$ git pr show -t 16563
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16563.diff
Webrev
Link to Webrev Comment