Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp #16667

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Nov 15, 2023

ProblemList 2 nsk jdi tests with Xcomp on all platforms


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16667/head:pull/16667
$ git checkout pull/16667

Update a local copy of the PR:
$ git checkout pull/16667
$ git pull https://git.openjdk.org/jdk.git pull/16667/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16667

View PR using the GUI difftool:
$ git pr show -t 16667

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16667.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2023

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@alexmenkov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@alexmenkov
Copy link
Author

/cc serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@alexmenkov
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp

Reviewed-by: cjplummer, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 3c6ffca: 8318219: RISC-V: C2 ExpandBits
  • 77a6966: 8320053: GHA: Cross-compile gtest code
  • 4f4d00f: 8319966: AIX: expected [[0:i4]] but found [[0:I4]] after JDK-8319882
  • 2e34a2e: 8318671: Potential uninitialized uintx value after JDK-8317683
  • fac6b51: 8319781: RISC-V: Refactor UseRVV related checks
  • bad6999: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask
  • fbe1937: 8319955: Improve dependencies removal during class unloading
  • 4c1540b: 8287284: C2: loop optimization performs split_thru_phi infinitely many times
  • 70f0c01: 8320054: Remove unused _count from NMT walker classes
  • e7486e8: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
  • ... and 3 more: https://git.openjdk.org/jdk/compare/d5abe49670d81b9c4749ce777ed6bf2886228f2f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2023
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@alexmenkov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

Going to push as commit 536b1ce.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 0bda467: 8319187: Add three eMudhra emSign roots
  • 3c6ffca: 8318219: RISC-V: C2 ExpandBits
  • 77a6966: 8320053: GHA: Cross-compile gtest code
  • 4f4d00f: 8319966: AIX: expected [[0:i4]] but found [[0:I4]] after JDK-8319882
  • 2e34a2e: 8318671: Potential uninitialized uintx value after JDK-8317683
  • fac6b51: 8319781: RISC-V: Refactor UseRVV related checks
  • bad6999: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask
  • fbe1937: 8319955: Improve dependencies removal during class unloading
  • 4c1540b: 8287284: C2: loop optimization performs split_thru_phi infinitely many times
  • 70f0c01: 8320054: Remove unused _count from NMT walker classes
  • ... and 4 more: https://git.openjdk.org/jdk/compare/d5abe49670d81b9c4749ce777ed6bf2886228f2f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2023
@openjdk openjdk bot closed this Nov 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@alexmenkov Pushed as commit 536b1ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the problemlist_jdi_xcomp branch November 15, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

3 participants