Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317357: Update links in building.md to use https rather than http #16695

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Nov 16, 2023

From the bug report: Building.md file contains a number of HTTP links that would need to be converted to HTTPS in order for clicking on the links on the OpenJDK web site at https://openjdk.org/groups/build/doc/building.html to work.

It is also best practice nowadays to always prefer https in links; most http requests are upgraded to https anyway.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317357: Update links in building.md to use https rather than http (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16695/head:pull/16695
$ git checkout pull/16695

Update a local copy of the PR:
$ git checkout pull/16695
$ git pull https://git.openjdk.org/jdk.git pull/16695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16695

View PR using the GUI difftool:
$ git pr show -t 16695

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16695.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2023

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 16, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317357: Update links in building.md to use https rather than http

Reviewed-by: iris, erikj, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 279 new commits pushed to the master branch:

  • 8ec6b8d: 8319876: Reduce memory consumption of VM_ThreadDump::doit
  • bbf52e0: 8319897: Move StackWatermark handling out of LockStack::contains
  • 129c470: 8311932: Suboptimal compiled code of nested loop over memory segment
  • 369bbec: 8319896: Remove monitor deflation from final audit
  • 1588dd9: 8319567: Update java/lang/invoke tests to support vm flags
  • 9727f4b: 8320199: Fix HTML 5 errors in java.math.BigInteger
  • d6aa7c8: 8314621: ClassNotFoundException due to lambda reference to elided anonymous inner class
  • 52e2878: 8319987: compilation of sealed classes leads to infinite recursion
  • b05e69f: 8320209: VectorMaskGen clobbers rflags on x86_64
  • f3ed275: 8319103: Popups that request focus are not shown on Linux with Wayland
  • ... and 269 more: https://git.openjdk.org/jdk/compare/202c0137b86cd7bcbe0c1eddf2657f45698ab667...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 16, 2023
@magicus
Copy link
Member Author

magicus commented Nov 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

Going to push as commit 9194d2c.
Since your change was applied there have been 280 commits pushed to the master branch:

  • 368e4f6: 8315801: [PPC64] JNI code should be more similar to the Panama implementation
  • 8ec6b8d: 8319876: Reduce memory consumption of VM_ThreadDump::doit
  • bbf52e0: 8319897: Move StackWatermark handling out of LockStack::contains
  • 129c470: 8311932: Suboptimal compiled code of nested loop over memory segment
  • 369bbec: 8319896: Remove monitor deflation from final audit
  • 1588dd9: 8319567: Update java/lang/invoke tests to support vm flags
  • 9727f4b: 8320199: Fix HTML 5 errors in java.math.BigInteger
  • d6aa7c8: 8314621: ClassNotFoundException due to lambda reference to elided anonymous inner class
  • 52e2878: 8319987: compilation of sealed classes leads to infinite recursion
  • b05e69f: 8320209: VectorMaskGen clobbers rflags on x86_64
  • ... and 270 more: https://git.openjdk.org/jdk/compare/202c0137b86cd7bcbe0c1eddf2657f45698ab667...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2023
@openjdk openjdk bot closed this Nov 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@magicus Pushed as commit 9194d2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the readme-https branch November 20, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

4 participants