-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317357: Update links in building.md to use https rather than http #16695
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 279 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 9194d2c.
Your commit was automatically rebased without conflicts. |
From the bug report: Building.md file contains a number of HTTP links that would need to be converted to HTTPS in order for clicking on the links on the OpenJDK web site at https://openjdk.org/groups/build/doc/building.html to work.
It is also best practice nowadays to always prefer https in links; most http requests are upgraded to https anyway.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16695/head:pull/16695
$ git checkout pull/16695
Update a local copy of the PR:
$ git checkout pull/16695
$ git pull https://git.openjdk.org/jdk.git pull/16695/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16695
View PR using the GUI difftool:
$ git pr show -t 16695
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16695.diff
Webrev
Link to Webrev Comment