8320618: NPE: Cannot invoke "java.lang.constant.ClassDesc.isArray()" because "this.sym" is null

[asotona]

ClassFile API StackMapGenerator caused a NPE for a test case with invalid sequence of instructions.
This fix simply avoids the NPE and adds StackMapsTest::testInvalidAALOADStack

Please review.

Thanks,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320618: NPE: Cannot invoke "java.lang.constant.ClassDesc.isArray()" because "this.sym" is null (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16793/head:pull/16793
$ git checkout pull/16793

Update a local copy of the PR:
$ git checkout pull/16793
$ git pull https://git.openjdk.org/jdk.git pull/16793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16793

View PR using the GUI difftool:
$ git pr show -t 16793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16793.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (21e0c62f)

[AlanBateman]

Good find.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320618: NPE: Cannot invoke "java.lang.constant.ClassDesc.isArray()" because "this.sym" is null

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 91279fc: 8319778: Remove unreachable code in ObjectSynchronizer::exit
• 6aa1976: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
• 4d50df6: 8320691: Timeout handler on Windows takes 2 hours to complete
• 0c9a61c: 8319220: Pattern matching switch with a lot of cases is unduly slow
• 26c3390: 8320383: refresh libraries cache on AIX in VMError::report
• fc31474: 8318913: The module-infos for --release data do not contain pre-set versions
• df1b896: 8320679: [JVMCI] invalid code in PushLocalFrame event message
• c75c388: 8318776: Require supports_cx8 to always be true
• 14557e7: 8314502: Change the comparator taking version of GrowableArray::find to be a template method
• 2802643: 8314243: Make VM_Exit::wait_for_threads_in_native_to_block wait for user threads time configurable
• ... and 6 more: https://git.openjdk.org/jdk/compare/99b9cb0a2eae1196f2127cd48e4085f19a90c4b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[asotona]

/integrate

[openjdk]

Going to push as commit 28d3762.
Since your change was applied there have been 18 commits pushed to the master branch:

• f6e5559: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
• bddcd08: 8304701: Request with timeout aborts later in-flight request on HTTP/1.1 cxn
• 91279fc: 8319778: Remove unreachable code in ObjectSynchronizer::exit
• 6aa1976: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
• 4d50df6: 8320691: Timeout handler on Windows takes 2 hours to complete
• 0c9a61c: 8319220: Pattern matching switch with a lot of cases is unduly slow
• 26c3390: 8320383: refresh libraries cache on AIX in VMError::report
• fc31474: 8318913: The module-infos for --release data do not contain pre-set versions
• df1b896: 8320679: [JVMCI] invalid code in PushLocalFrame event message
• c75c388: 8318776: Require supports_cx8 to always be true
• ... and 8 more: https://git.openjdk.org/jdk/compare/99b9cb0a2eae1196f2127cd48e4085f19a90c4b4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 28d3762.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.