8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"

[albertnetymk]

Simple fix to reduce live set so that after the triggered full-gc, there is still some memory left.

Test: ~2/10 failure before the fix and no failure observed for 100 iterations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" (Bug - P4)

Reviewers

• Stefan Johansson (@kstefanj - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16870/head:pull/16870
$ git checkout pull/16870

Update a local copy of the PR:
$ git checkout pull/16870
$ git pull https://git.openjdk.org/jdk.git pull/16870/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16870

View PR using the GUI difftool:
$ git pr show -t 16870

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16870.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e8333cc0)

[albertnetymk]

/label add hotspot-gc

[openjdk]

@albertnetymk
The hotspot-gc label was successfully added.

[kstefanj]

Looks good.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"

Reviewed-by: sjohanss, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• da09eab: 8319980: [JVMCI] libgraal should reuse Thread instances as C2 does
• 33b26f7: 8319123: Implement JEP 461: Stream Gatherers (Preview)
• 04ad98e: 8315458: Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview)
• 03759e8: 8320304: Refactor and simplify monitor deflation functions
• da7cf25: 8320665: update jdk_core at open/test/jdk/TEST.groups
• c9d15f7: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
• 61653a1: 8320830: [AIX] Dont mix os::dll_load() with direct dlclose() calls
• 8b102ed: 8321063: AArch64: Zero build fails after JDK-8320368
• 6941369: 8320921: GHA: Parallelize hotspot_compiler test jobs
• 0d14636: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object
• ... and 36 more: https://git.openjdk.org/jdk/compare/dc256fbc6490f8163adb286dbb7380c10e5e1e06...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 6938474.
Since your change was applied there have been 46 commits pushed to the master branch:

• da09eab: 8319980: [JVMCI] libgraal should reuse Thread instances as C2 does
• 33b26f7: 8319123: Implement JEP 461: Stream Gatherers (Preview)
• 04ad98e: 8315458: Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview)
• 03759e8: 8320304: Refactor and simplify monitor deflation functions
• da7cf25: 8320665: update jdk_core at open/test/jdk/TEST.groups
• c9d15f7: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
• 61653a1: 8320830: [AIX] Dont mix os::dll_load() with direct dlclose() calls
• 8b102ed: 8321063: AArch64: Zero build fails after JDK-8320368
• 6941369: 8320921: GHA: Parallelize hotspot_compiler test jobs
• 0d14636: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object
• ... and 36 more: https://git.openjdk.org/jdk/compare/dc256fbc6490f8163adb286dbb7380c10e5e1e06...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 6938474.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.