New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321141: VM build issue on MacOS after JDK-8267532 #16914
Conversation
👋 Welcome back kvn! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vnkozlov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thank you, @DamonFool , for review. |
|
I consider this change trivial and will push it. |
/integrate |
Going to push as commit 02ffab1.
Your commit was automatically rebased without conflicts. |
JDK-8267532 added new method
ciMethodData::exception_handler_bci_to_data()
which hasShouldNotReachHere()
call on one exit without returning any value.Unfortunately
ATTRIBUTE_NORETURN
attribute inShouldNotReachHere()
seems don't work with older versions of Xcode.The fix is to add
return
statement.Tested with old Xcode (12.4) I have. Also tested with tier1 which includes builds.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16914/head:pull/16914
$ git checkout pull/16914
Update a local copy of the PR:
$ git checkout pull/16914
$ git pull https://git.openjdk.org/jdk.git pull/16914/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16914
View PR using the GUI difftool:
$ git pr show -t 16914
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16914.diff
Webrev
Link to Webrev Comment