8321637: Simplify if statement in ArraysSupport::hugeLength

[johnshajiang]

It looks the else-if and else clauses in method ArraysSupport::hugeLength could be simplified by Math::max.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321637: Simplify if statement in ArraysSupport::hugeLength (Enhancement - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17043/head:pull/17043
$ git checkout pull/17043

Update a local copy of the PR:
$ git checkout pull/17043
$ git pull https://git.openjdk.org/jdk.git pull/17043/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17043

View PR using the GUI difftool:
$ git pr show -t 17043

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17043.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@johnshajiang The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4e874d35)

[DamonFool]

The JBS should be an enhancement, not a bug, right?

[johnshajiang]

@DamonFool

The JBS should be an enhancement, not a bug, right?

Yes, it should be an enhancement rather than a bug.

Thanks @AlanBateman for changing this JBS type.

[johnshajiang]

Could this simple PR be reviewed?

[stuart-marks]

This change would make the code shorter, but in my opinion, it obscures what's going on. This code tries to be very careful about avoiding problems caused by integer overflow/wraparound, and in order to do that, it needs to make sure that the full range of int values is handled properly. With the explicit if/else code, this is clear. Using Math.max() instead tends to make this obscure.

This came up previously; see

#1617 (comment)

[johnshajiang]

@stuart-marks
Thanks for your clarification!

Just closed this PR and JBS.