8322018: Test java/lang/String/CompactString/MaxSizeUTF16String.java fails with -Xcomp

[RogerRiggs]

The test java/lang/String/CompactString/MaxSizeUTF16String.java fails when run with -Xcomp.

Both the java implementation and the intrinsic for StringUTF16.toBytes() allocate memory for a copy of the string.
The java implementation of toBytes() throws an exception with a message in terms of length of the string.
The intrinsic uses a generic message when allocating a byte array that is too large for the implementation.

Test should accept either message on the OOME exception, the message is an implementation detail and should reflect the cause of the error and not be confused with a general out of java heap message.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322018: Test java/lang/String/CompactString/MaxSizeUTF16String.java fails with -Xcomp (Bug - P3)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17095/head:pull/17095
$ git checkout pull/17095

Update a local copy of the PR:
$ git checkout pull/17095
$ git pull https://git.openjdk.org/jdk.git pull/17095/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17095

View PR using the GUI difftool:
$ git pr show -t 17095

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17095.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (34c10555)

[jaikiran]

The update to the definition introduces a new @run with -Xcomp so as to explicitly control the test run instead of relying on external test launch mechanisms to pass around the -Xcomp. That then means that the introduction of @requires vm.flagless, in this change, is fine.
The change in the test logic itself looks reasonable to me based on what's explained in the PR description.

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322018: Test java/lang/String/CompactString/MaxSizeUTF16String.java fails with -Xcomp

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• d632d74: 8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized
• ddbbd36: 8320279: Link issues in java.xml module-info.java
• c8ad7b7: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RogerRiggs]

/integrate

[openjdk]

Going to push as commit 6311dab.
Since your change was applied there have been 20 commits pushed to the master branch:

• bdebf19: 8322175: test/langtools/tools/javac/classreader/BadMethodParameter.java doesn't compile
• 20de541: 8322040: Missing array bounds check in ClassReader.parameter
• b31454e: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
• 0be0775: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
• 6dfb812: 8321823: Remove redundant PhaseGVN transform_no_reclaim
• a7dde57: 8322057: Memory leaks in creating jfr symbol array
• 692be57: 8322065: Initial nroff manpage generation for JDK 23
• d02bc87: 8309981: Remove expired flags in JDK 23
• 8b24851: 8321480: ISO 4217 Amendment 176 Update
• c328f95: 8296787: Unify debug printing format of X.509 cert serial numbers
• ... and 10 more: https://git.openjdk.org/jdk/compare/cf948548c390c42ca63525d41a9d63ff31349c3a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs Pushed as commit 6311dab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.