Skip to content

8309981: Remove expired flags in JDK 23 #17107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Dec 14, 2023

All expired flags are removed from the flags table.

The two documented flags have their documentation moved from the obsolete section to the removed section.

The link to JDK 22 removed flags is added to the list.

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309981: Remove expired flags in JDK 23 (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17107/head:pull/17107
$ git checkout pull/17107

Update a local copy of the PR:
$ git checkout pull/17107
$ git pull https://git.openjdk.org/jdk.git pull/17107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17107

View PR using the GUI difftool:
$ git pr show -t 17107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17107.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@dholmes-ora
Copy link
Member Author

/label add hotspot

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot hotspot-dev@openjdk.org labels Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@dholmes-ora
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 14, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309981: Remove expired flags in JDK 23

Reviewed-by: alanb, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • c328f95: 8296787: Unify debug printing format of X.509 cert serial numbers
  • fde5b16: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
  • 45a9ade: 8202598: keytool -certreq output contains inconsistent line separators
  • 62b7c5e: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags
  • 69014cd: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • 5a97dbf: 8322034: Parallel: Remove unused methods in PSAdaptiveSizePolicy
  • 2838a91: 8288989: Make tests not depend on the source code
  • d2ba3b1: 8312150: Remove -Xnoagent option
  • d632d74: 8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized
  • ddbbd36: 8320279: Link issues in java.xml module-info.java
  • ... and 1 more: https://git.openjdk.org/jdk/compare/cf948548c390c42ca63525d41a9d63ff31349c3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2023
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@dholmes-ora
Copy link
Member Author

Thanks for the reviews @AlanBateman and @vnkozlov .

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

Going to push as commit d02bc87.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 8b24851: 8321480: ISO 4217 Amendment 176 Update
  • c328f95: 8296787: Unify debug printing format of X.509 cert serial numbers
  • fde5b16: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
  • 45a9ade: 8202598: keytool -certreq output contains inconsistent line separators
  • 62b7c5e: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags
  • 69014cd: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • 5a97dbf: 8322034: Parallel: Remove unused methods in PSAdaptiveSizePolicy
  • 2838a91: 8288989: Make tests not depend on the source code
  • d2ba3b1: 8312150: Remove -Xnoagent option
  • d632d74: 8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized
  • ... and 2 more: https://git.openjdk.org/jdk/compare/cf948548c390c42ca63525d41a9d63ff31349c3a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2023
@openjdk openjdk bot closed this Dec 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@dholmes-ora Pushed as commit d02bc87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8309981-only branch December 14, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants