Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323089: networkaddress.cache.ttl is not a system property #17671

Closed
wants to merge 3 commits into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Feb 1, 2024

Please review this documentation change that:

  • removes networkcache.cache.*.ttl properties from the System properties page
  • Adds a link to the Security class where security properties are mentioned

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323089: networkaddress.cache.ttl is not a system property (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17671/head:pull/17671
$ git checkout pull/17671

Update a local copy of the PR:
$ git checkout pull/17671
$ git pull https://git.openjdk.org/jdk.git pull/17671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17671

View PR using the GUI difftool:
$ git pr show -t 17671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17671.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8323089 8323089: networkaddress.cache.ttl is not a system property Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@djelinski The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Feb 1, 2024
@djelinski djelinski marked this pull request as ready for review February 1, 2024 19:22
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323089: networkaddress.cache.ttl is not a system property

Reviewed-by: alanb, jpai, aefimov, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • fd89b33: 8316992: Potential null pointer from get_current_thread JVMCI helper function.
  • d1c8215: 8325194: GHA: Add macOS M1 testing
  • f356970: 8322535: Change default AArch64 SpinPause instruction
  • b75c134: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
  • 4cd3187: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • b02599d: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code
  • 6d911f6: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state
  • 542b0b6: 8324126: Error message for mistyping -XX:+Unlock...Options is not helpful
  • 9ee9f28: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 729ae1d: 8325266: Enable this-escape javac warning in jdk.javadoc
  • ... and 44 more: https://git.openjdk.org/jdk/compare/6b84f9bb3ee4362bf9daa4fb3905b168f9035336...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2024
Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Daniel, these changes look good to me.

Copy link
Member

@AlekseiEfimov AlekseiEfimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daniel,
The changes looks good to me.

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djelinski
Copy link
Member Author

Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

Going to push as commit efa071d.
Since your change was applied there have been 117 commits pushed to the master branch:

  • 2546afe: 8325451: Missed elimination of assertion predicates
  • af7eeff: 8325565: Remove unused SpaceClosure
  • 232d136: 8324890: C2 SuperWord: refactor out VLoop, make unrolling_analysis static, remove init/reset mechanism
  • 71d2dbd: 8325464: GCCause.java out of sync with gcCause.hpp
  • 6c7029f: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
  • e33d8a2: 8311076: RedefineClasses doesn't check for ConstantPool overflow
  • 6303c0e: 8325569: ProblemList gc/parallel/TestAlwaysPreTouchBehavior.java on linux
  • 3ebe6c1: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only
  • d39b7ba: 8316460: 4 javax/management tests ignore VM flags
  • ac4607e: 8226919: attach in linux hangs due to permission denied accessing /proc/pid/root
  • ... and 107 more: https://git.openjdk.org/jdk/compare/6b84f9bb3ee4362bf9daa4fb3905b168f9035336...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2024
@openjdk openjdk bot closed this Feb 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@djelinski Pushed as commit efa071d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the networkcache-docs branch February 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

5 participants