Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325150: (tz) Update Timezone Data to 2024a #17743

Closed
wants to merge 1 commit into from

Conversation

johnyjose30
Copy link
Contributor

@johnyjose30 johnyjose30 commented Feb 7, 2024

Timezone data 2024a changes


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325150: (tz) Update Timezone Data to 2024a (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17743/head:pull/17743
$ git checkout pull/17743

Update a local copy of the PR:
$ git checkout pull/17743
$ git pull https://git.openjdk.org/jdk.git pull/17743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17743

View PR using the GUI difftool:
$ git pr show -t 17743

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17743.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2024

👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@johnyjose30
Copy link
Contributor Author

/reviewer credit @coffeys @naotoj

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 7, 2024
@openjdk
Copy link

openjdk bot commented Feb 7, 2024

@johnyjose30
Reviewer coffeys successfully credited.

Reviewer naoto successfully credited.

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

@johnyjose30 The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Feb 7, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2024

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325150: (tz) Update Timezone Data to 2024a

Reviewed-by: coffeys, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @naotoj, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 7, 2024
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnyjose30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@johnyjose30
Your change (at version c38bde8) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Feb 8, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

Going to push as commit 917838e.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 43089bf: 8325399: Add tests for virtual threads doing Selector operations
  • d109903: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 1fb9e3d: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments
  • 9cccf05: 8325367: Rename nsk_list.h
  • be7cc1c: 8323681: SA PointerFinder code should support G1
  • fbd15b2: 8325189: Enable this-escape javac warning in java.base
  • 299a8ee: 8325302: Files.move(REPLACE_EXISTING) throws NoSuchFileException on deleted target
  • 3a1f4d0: 8325268: Add policy statement to langtools makefiles concerning warnings
  • 18e24d0: 8325109: Sort method modifiers in canonical order
  • a3a2b1f: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread
  • ... and 45 more: https://git.openjdk.org/jdk/compare/af32262c28f6dd012307c249156d909bb891e75b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2024
@openjdk openjdk bot closed this Feb 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@coffeys @johnyjose30 Pushed as commit 917838e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
4 participants