8327829: [JVMCI] runtime/ClassUnload/ConstantPoolDependsTest.java fails on libgraal

[dougxc]

This PR fixes failures of runtime/ClassUnload/ConstantPoolDependsTest.java for similar reasons to those stated in #18044.

The fix is also similar: use a helper that retries class unloading.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327829: [JVMCI] runtime/ClassUnload/ConstantPoolDependsTest.java fails on libgraal (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18202/head:pull/18202
$ git checkout pull/18202

Update a local copy of the PR:
$ git checkout pull/18202
$ git pull https://git.openjdk.org/jdk.git pull/18202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18202

View PR using the GUI difftool:
$ git pr show -t 18202

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18202.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1123b1c7)

[dholmes-ora]

Looks good.

Thanks

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327829: [JVMCI] runtime/ClassUnload/ConstantPoolDependsTest.java fails on libgraal

Reviewed-by: dholmes, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 379ad1f: 8312444: Delete unused parameters and variables in SocketPermission
• 782206b: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main
• 0776fff: 8327794: RISC-V: enable extension features based on impid (Rivos specific change)
• cfd9209: 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
• 2cf3524: 8325433: Type annotations on primitive types are not linked
• 5056902: 8327361: Update some comments after JDK-8139457
• 78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
• 1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
• 013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
• b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
• ... and 15 more: https://git.openjdk.org/jdk/compare/63dd6d1ac5b367e9c475779349581506d5c81d16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit f3d0c45.
Since your change was applied there have been 36 commits pushed to the master branch:

• d5b95a0: 8327631: Update IANA Language Subtag Registry to Version 2024-03-07
• 966a42f: 8324868: debug agent does not properly handle interrupts of a virtual thread
• 22f10e0: 8327856: Convert applet test SpanishDiacriticsTest.java to a main program
• 7283c8b: 8327972: Convert java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html applet test to main
• 30249c4: 8327838: Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main
• 94b4ed5: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
• b9c3dc3: 8327738: Remove unused internal method sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator
• 5b41466: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe
• 313e814: 8324682: Remove redefinition of NULL for XLC compiler
• 8a3bdd5: 8327995: Remove unused Unused_Variable
• ... and 26 more: https://git.openjdk.org/jdk/compare/63dd6d1ac5b367e9c475779349581506d5c81d16...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit f3d0c45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.