8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main

[TejeshR13]

Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main (Bug - P4)

Reviewers

• Abhishek Kumar (@kumarabhi006 - Committer) ⚠️ Review applies to 8c40a81b
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18260/head:pull/18260
$ git checkout pull/18260

Update a local copy of the PR:
$ git checkout pull/18260
$ git pull https://git.openjdk.org/jdk.git pull/18260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18260

View PR using the GUI difftool:
$ git pr show -t 18260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18260.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TejeshR13 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (66f9e8e7)
• 01: Full - Incremental (8c40a81b)
• 00: Full (130bf5b3)

[openjdk]

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main

Reviewed-by: abhiscxk, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 209 new commits pushed to the master branch:

• dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
• d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
• 000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• fbeac98: 8328379: Convert URLDragTest.html applet test to main
• 96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
• 4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• d3f3011: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
• e5e7cd2: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
• 1b68c73: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
• ... and 199 more: https://git.openjdk.org/jdk/compare/53c4714aab2e072ba18631875dcaa3b2d5d22243...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kumarabhi006]

LGTM.

[prsadhuk]

I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted
Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...

[TejeshR13]

I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...

You mean to say the border of JEditorPane is 1 pixel thicker ?

[prsadhuk]

I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...

You mean to say the border of JEditorPane is 1 pixel thicker ?

it doesn't look exactly same subjectively...

[TejeshR13]

I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...

You mean to say the border of JEditorPane is 1 pixel thicker ?

it doesn't look exactly same subjectively...

Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?

[prsadhuk]

I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...

You mean to say the border of JEditorPane is 1 pixel thicker ?

it doesn't look exactly same subjectively...

Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?

I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case, probably the instructions should be amended accordingly...Let them verify once..

[prsadhuk]

I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...

You mean to say the border of JEditorPane is 1 pixel thicker ?

it doesn't look exactly same subjectively...

Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?

I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case, probably the instructions should be amended accordingly...Let them verify once..

or maybe run the test with uiScale 1.0 as I believe the golden images are generated without any scaling and windows has default 1.25/1.5 scaling

[TejeshR13]

@prsadhuk With scaling 1.0 it'll appear this way. I think it's supposed to be 1.0 scaling and its looking similar now.

[prsadhuk]

@prsadhuk With scaling 1.0 it'll appear this way. I think it's supposed to be 1.0 scaling and its looking similar now.

I am not sure..it still seems 1.25 bigger than golden image..."similar" word has different connotation and is very subjective....is it intentional that "same" was not mentioned?
What if we say, Earth and Mars are similar as they are planets...

[TejeshR13]

@prsadhuk With scaling 1.0 it'll appear this way. I think it's supposed to be 1.0 scaling and its looking similar now.

I am not sure..it still seems 1.25 bigger than golden image..."similar" word has different connotation and is very subjective....is it intentional that "same" was not mentioned? What if we say, Earth and Mars are similar as they are planets...

Then shall I problemlist it?

[prsadhuk]

Ideally yes, but you can discuss in the meeting since harshita/damon has not come back on this..

[honkar-jdk]

I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case, probably the instructions should be amended accordingly...Let them verify once..

@prsadhuk @TejeshR13 I do see slight difference in borders on fractional scales 1.25,1.75. This looks similar to the border scaling issue fixed as part #11571, #10274. The border scaling fix was extended to line, etched borders and borders for JInternalFrame.

This case is slightly different, in the sense html is parsed to paint the border of desired thickness but I believe the underlying issue is the same - painting of borders on fractional scales on Windows.

[prrace]

This test was written before there was hidpi. So I am sure it is 100% so definitely you should specify that in the test to have any chance.
The height of the text doesn't matter, nor spacing inside the cells.
I'd say it is "similar enough" with 1.0 scaling. There's not been a bug about this yet.

[TejeshR13]

This test was written before there was hidpi. So I am sure it is 100% so definitely you should specify that in the test to have any chance. The height of the text doesn't matter, nor spacing inside the cells. I'd say it is "similar enough" with 1.0 scaling. There's not been a bug about this yet.

Updated the instructions and scaling set to 1.0.

[TejeshR13]

/integrate

[openjdk]

Going to push as commit 481473e.
Since your change was applied there have been 209 commits pushed to the master branch:

• dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
• d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
• 000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• fbeac98: 8328379: Convert URLDragTest.html applet test to main
• 96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
• 4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• d3f3011: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
• e5e7cd2: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
• 1b68c73: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
• ... and 199 more: https://git.openjdk.org/jdk/compare/53c4714aab2e072ba18631875dcaa3b2d5d22243...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TejeshR13 Pushed as commit 481473e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.