Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321428: Depreciate java.beans.beancontext.* #18413

Closed
wants to merge 1 commit into from

Conversation

larry-cable
Copy link

@larry-cable larry-cable commented Mar 20, 2024

https://bugs.openjdk.org/browse/JDK-8321428


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8320930 to be approved

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8321428

Issues

  • JDK-8321428: Deprecate for removal the package java.beans.beancontext (Bug - P4) ⚠️ Title mismatch between PR and JBS. ⚠️ Issue is not open.
  • JDK-8320930: Deprecate for removal the package java.beans.beancontext (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18413/head:pull/18413
$ git checkout pull/18413

Update a local copy of the PR:
$ git checkout pull/18413
$ git pull https://git.openjdk.org/jdk.git pull/18413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18413

View PR using the GUI difftool:
$ git pr show -t 18413

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18413.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Mar 20, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2024

Hi @larry-cable, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user larry-cable" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@larry-cable The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 20, 2024
@larry-cable larry-cable changed the title Depreciate java.beans.beancontext.* 8321428: Depreciate java.beans.beancontext.* Mar 21, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Mar 22, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

@@ -33,4 +33,5 @@
*
* @since 1.2
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? Were you intending to add something here ? If not revert the blank line.

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for
(1) that blank line
(2) skara would like you to rename the PR to match the bug + approved CSR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
2 participants