New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321428: Depreciate java.beans.beancontext.* #18413
Conversation
…beans.beancontext
Hi @larry-cable, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user larry-cable" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
@larry-cable The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@@ -33,4 +33,5 @@ | |||
* | |||
* @since 1.2 | |||
*/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?? Were you intending to add something here ? If not revert the blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except for
(1) that blank line
(2) skara would like you to rename the PR to match the bug + approved CSR.
https://bugs.openjdk.org/browse/JDK-8321428
Progress
Integration blocker
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18413/head:pull/18413
$ git checkout pull/18413
Update a local copy of the PR:
$ git checkout pull/18413
$ git pull https://git.openjdk.org/jdk.git pull/18413/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18413
View PR using the GUI difftool:
$ git pr show -t 18413
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18413.diff
Webrev
Link to Webrev Comment