Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only #18449

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 22, 2024

Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18449/head:pull/18449
$ git checkout pull/18449

Update a local copy of the PR:
$ git checkout pull/18449
$ git pull https://git.openjdk.org/jdk.git pull/18449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18449

View PR using the GUI difftool:
$ git pr show -t 18449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18449.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • bc73963: 8328303: 3 JDI tests timed out with UT enabled
  • 476421e: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main
  • c013fa1: 8328194: Add a test to check default rendering engine
  • f33a844: 8325536: JVM crash during CDS archive creation with -XX:+AllowArchivingWithJavaAgent
  • 4324e3b: 8328612: AdaptiveSizePolicySpaceOverheadTester::is_exceeded() print max_eden_size twice
  • c7bbf84: 8328190: Convert AWTPanelSmoothWheel.html applet test to main
  • 23ebd9c: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
  • 4d932d6: 8326853: Missing @since tags for Charset related methods added in Java 10
  • ce7ebaa: 8328812: Update and move siphash license
  • b7a51dd: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main
  • ... and 38 more: https://git.openjdk.org/jdk/compare/e41bc42deb22615c9b93ee639d04e9ed2bd57f64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these lines are unchanged, I couldn't add comments there.

So, few suggestions:

  1. @author tag can be removed.
  2. You may fix spacing issues as well like
    TextArea textArea = new TextArea(5,5);
    Checkbox radioButton = new Checkbox("Hello" ,true, checkboxGroup);
    and other placess too.
  3. Column limit exceeding.

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no changes to the test except for formatting ?
But it now passes ? Could be it has passed for many years.
We'll see how it does in CI over the long term.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit f67ec19.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 93579c2: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • b235682: 8328709: AIX os::get_summary_cpu_info support Power 10
  • 19a0151: 8328700: Unused import and variable should be deleted in regex package
  • cf9b5a7: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • acc4a82: 8328862: Remove unused GrowableArrayFilterIterator
  • 9f920b9: 8324655: Identify integer minimum and maximum patterns created with if statements
  • c7b9dc4: 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals
  • bc73963: 8328303: 3 JDI tests timed out with UT enabled
  • 476421e: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main
  • c013fa1: 8328194: Add a test to check default rendering engine
  • ... and 45 more: https://git.openjdk.org/jdk/compare/e41bc42deb22615c9b93ee639d04e9ed2bd57f64...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@prsadhuk Pushed as commit f67ec19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8079786 branch March 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants