New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only #18449
Conversation
….java fails for Mac only
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these lines are unchanged, I couldn't add comments there.
So, few suggestions:
- @author tag can be removed.
- You may fix spacing issues as well like
TextArea textArea = new TextArea(5,5);
Checkbox radioButton = new Checkbox("Hello" ,true, checkboxGroup);
and other placess too. - Column limit exceeding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So no changes to the test except for formatting ?
But it now passes ? Could be it has passed for many years.
We'll see how it does in CI over the long term.
/integrate |
Going to push as commit f67ec19.
Your commit was automatically rebased without conflicts. |
Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted...
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18449/head:pull/18449
$ git checkout pull/18449
Update a local copy of the PR:
$ git checkout pull/18449
$ git pull https://git.openjdk.org/jdk.git pull/18449/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18449
View PR using the GUI difftool:
$ git pr show -t 18449
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18449.diff
Webrev
Link to Webrev Comment