JDK-8328786: [AIX] move some important warnings/errors from trcVerbose to UL

[MBaesken]

trcVerbose is a macro that can be used in the AIX OpenJDK codebase.
It boils down to if (Verbose) { <print message> } ;
However this means that it can only be used in non product JVM because Verbose is a develop flag.
So more important warning/error/info messages should better be moved e.g. to UL so that they are usable in product JVMs too,

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328786: [AIX] move some important warnings/errors from trcVerbose to UL (Bug - P4)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18517/head:pull/18517
$ git checkout pull/18517

Update a local copy of the PR:
$ git checkout pull/18517
$ git pull https://git.openjdk.org/jdk.git pull/18517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18517

View PR using the GUI difftool:
$ git pr show -t 18517

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18517.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328786: [AIX] move some important warnings/errors from trcVerbose to UL

Reviewed-by: lucy, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 6b1b0e9: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
• bc546c2: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
• af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
• a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
• 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
• ecd2b71: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails
• c2979c1: 8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
• 5698f7a: 8329134: Reconsider TLAB zapping
• 4a14cba: 8329213: Better validation for com.sun.security.ocsp.useget option
• ... and 35 more: https://git.openjdk.org/jdk/compare/d0a265039a36292d87b249af0e8977982e5acc7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b761ba52)

[TheRealMDoerr]

I think that there were problems with UL during early initialization. I guess that trcVerbose has been used as workaround. Did you check if the log messages get still printed?
@tstuefe may know more about why this is used.

[RealLucy]

LGTM.
Maybe you want to delay integration until the concern from @TheRealMDoerr is resolved.

[MBaesken]

I think that there were problems with UL during early initialization. I guess that trcVerbose has been used as workaround. Did you check if the log messages get still printed? @tstuefe may know more about why this is used.

Yes very early in the JVM runtime, the UL is not working (means: no output). But this is even true to some extent for -XX:+Verbose . Example - I added UL , trcVerbose AND printf at libperfstat::init (this is one place I want to change in the PR)

bool libperfstat::init() {
  const char* libperfstat = "/usr/lib/libperfstat.a(shr_64.o)";
  char ebuf[512];
  g_libhandle = os::dll_load(libperfstat, ebuf, sizeof(ebuf));
  log_warning(os)("Loaded libperfstat");
  printf("trace via printf - Loaded libperfstat\n");
  trcVerbose("trace verbose - Loaded libperfstat");

Unfortunately only the printf output is visible; UL and traceVerbose is not visible.

[tstuefe]

okay

[MBaesken]

/integrate

[openjdk]

Going to push as commit 8efd7aa.
Since your change was applied there have been 84 commits pushed to the master branch:

• f26e430: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If
• e5e21a8: 8328702: C2: Crash during parsing because sub type check is not folded
• f762637: 8326962: C2 SuperWord: cache VPointer
• 2931458: 8328938: C2 SuperWord: disable vectorization for large stride and scale
• 4196688: 8329494: Serial: Merge GenMarkSweep into MarkSweep
• 8020183: 8329470: Remove obsolete CDS SharedStrings tests
• 8267d65: 8329564: [JVMCI] TranslatedException::debugPrintStackTrace does not work in the libjvmci compiler.
• 16576b8: 8328957: Update PKCS11Test.java to not use hardcoded path
• 375bfac: 8327474: Review use of java.io.tmpdir in jdk tests
• 233619b: 8329557: Fix statement around MathContext.DECIMAL128 rounding
• ... and 74 more: https://git.openjdk.org/jdk/compare/d0a265039a36292d87b249af0e8977982e5acc7b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 8efd7aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.