8328383: Method is not used: com.sun.tools.javac.comp.Attr::thisSym

[vicente-romero-oracle]

Please review this simple fix that is just removing a method not used by any client. As indicated in the title the method belong to class com.sun.tools.javac.comp.Attr

TIA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328383: Method is not used: com.sun.tools.javac.comp.Attr::thisSym (Bug - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18566/head:pull/18566
$ git checkout pull/18566

Update a local copy of the PR:
$ git checkout pull/18566
$ git pull https://git.openjdk.org/jdk.git pull/18566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18566

View PR using the GUI difftool:
$ git pr show -t 18566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18566.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328383: Method is not used: com.sun.tools.javac.comp.Attr::thisSym

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• ee09801: 8328352: Serial: Inline SerialBlockOffsetSharedArray
• bea493b: 8236736: Change notproduct JVM flags to develop flags
• 80c54b4: 8328932: Parallel: Proper partial object setup in fill_dense_prefix_end
• d954f3b: 8329493: Parallel: Remove unused ParallelArguments::heap_max_size_bytes
• bdd9438: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
• e3e6c2a: 8328278: Do not print the tenuring threshold in AgeTable::print_on
• 16b842a: 8329355: Test compiler/c2/irTests/TestIfMinMax.java fails on RISC-V
• 92f5c0b: 8323682: C2: guard check is not generated in Arrays.copyOfRange intrinsic when allocation is eliminated by EA
• 866e7b6: 8329174: update CodeBuffer layout in comment after constants section moved
• f88f31d: 8328137: PreserveAllAnnotations can cause failure of class retransformation
• ... and 24 more: https://git.openjdk.org/jdk/compare/5698f7ad29c939b7e52882ace575dd7113bf41de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6ef9088f)

[lahodaj]

Looks OK.

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit 1c69193.
Since your change was applied there have been 34 commits pushed to the master branch:

• ee09801: 8328352: Serial: Inline SerialBlockOffsetSharedArray
• bea493b: 8236736: Change notproduct JVM flags to develop flags
• 80c54b4: 8328932: Parallel: Proper partial object setup in fill_dense_prefix_end
• d954f3b: 8329493: Parallel: Remove unused ParallelArguments::heap_max_size_bytes
• bdd9438: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
• e3e6c2a: 8328278: Do not print the tenuring threshold in AgeTable::print_on
• 16b842a: 8329355: Test compiler/c2/irTests/TestIfMinMax.java fails on RISC-V
• 92f5c0b: 8323682: C2: guard check is not generated in Arrays.copyOfRange intrinsic when allocation is eliminated by EA
• 866e7b6: 8329174: update CodeBuffer layout in comment after constants section moved
• f88f31d: 8328137: PreserveAllAnnotations can cause failure of class retransformation
• ... and 24 more: https://git.openjdk.org/jdk/compare/5698f7ad29c939b7e52882ace575dd7113bf41de...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 1c69193.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.