8329430: MetaspaceShared::preload_and_dump should clear pending exception

[calvinccheung]

Please review this simple fix for clearing the pending exception in MetaspaceShared::preload_and_dump().

Passed tiers 1 - 4 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329430: MetaspaceShared::preload_and_dump should clear pending exception (Bug - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18777/head:pull/18777
$ git checkout pull/18777

Update a local copy of the PR:
$ git checkout pull/18777
$ git pull https://git.openjdk.org/jdk.git pull/18777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18777

View PR using the GUI difftool:
$ git pr show -t 18777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18777.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329430: MetaspaceShared::preload_and_dump should clear pending exception

Reviewed-by: iklam, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• def2577: 8330215: Trim working set for OldObjectSamples
• 2f11afd: 8330172: G1: Consolidate update_bot_for_block and update_bot_for_obj in HeapRegion
• 31a1f9c: 8307143: CredentialsCache.cacheName should not be static
• 274c805: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1
• 140f567: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs
• a293bdf: 8330197: Make javac/diags/example release agnostic
• da75e01: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic
• ddc3921: 8330103: Compiler memory statistics should keep separate records for C1 and C2
• 273df62: 8328792: Parallel: Refactor PSParallelCompact::summary_phase
• a3fecdb: 8329764: G1: Handle null references during verification first
• ... and 11 more: https://git.openjdk.org/jdk/compare/397d94831033e91c7a849774bf4e80d8f1c8ec66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4b4a0235)

[iklam]

LGTM

[tstuefe]

Okay

[calvinccheung]

Thanks @iklam, @tstuefe for the review.

/integrate

[openjdk]

Going to push as commit 76cbe48.
Since your change was applied there have been 34 commits pushed to the master branch:

• f7c8413: 8326116: JFR: Add help option to -XX:StartFlightRecording
• 941bee1: 8327640: Allow NumberFormat strict parsing
• 2ede143: 8330279: Typo in java.text.Bidi class description
• 90df3b7: 8329190: (ch) DatagramChannel.receive should throw ClosedChannelException when called on closed channel
• f11a496: 8180450: secondary_super_cache does not scale well
• bfff02e: 8330165: C2: make superword consistently use PhaseIdealLoop::register_new_node()
• e073d5b: 8329665: fatal error: memory leak: allocating without ResourceMark
• 6e77d91: 8330261: Clean up linking steps
• 61fa4d4: 8330351: Remove the SHARED_LIBRARY and STATIC_LIBRARY macros
• 56ff87a: 8330359: G1: Remove unused forward declaration in g1BlockOffsetTable.hpp
• ... and 24 more: https://git.openjdk.org/jdk/compare/397d94831033e91c7a849774bf4e80d8f1c8ec66...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 76cbe48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.