8330755: ProblemList files have entries referring to non-existent tests

[dougxc]

This PR adds a check for the format of ProblemList files and ensures they only have entries referring to existing tests.

The cleanups in the second commit of this PR were done based on the output of CheckProblemLists:

> make test TEST=build/problemLists/CheckProblemLists.java
...
STDOUT:
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-Virtual.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-Xcomp.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-generational-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jaxp/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Xcomp.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-generational-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/langtools/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/lib-test/ProblemList.txt
Checked 13 problem list files
Test roots:
  /Users/dnsimon/dev/jdk-jdk/open/test/jdk
  /Users/dnsimon/dev/jdk-jdk/open/test/lib-test
  /Users/dnsimon/dev/jdk-jdk/open/test/failure_handler/test
  /Users/dnsimon/dev/jdk-jdk/open/test/jaxp
  /Users/dnsimon/dev/jdk-jdk/open/test/langtools
  /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg
Following errors found:
/Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList.txt:174: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java does not exist under any test root
vmTestbase/gc/lock/jni/jnilock002/TestDescription.java 8192647 generic-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt:77: TestAndIssue[test=java/util/Properties/StoreReproducibilityTest.java, issueId=0000000] duplicates /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt:76
java/util/Properties/StoreReproducibilityTest.java 0000000 generic-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:516: java/lang/management/MemoryMXBean/PendingAllGC.sh does not exist under any test root
java/lang/management/MemoryMXBean/PendingAllGC.sh               8158837 generic-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:667: javax/swing/JFileChooser/6798062/bug6798062.java does not exist under any test root
javax/swing/JFileChooser/6798062/bug6798062.java 8146446 windows-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:775: javax/swing/JTabbedPane/4666224/bug4666224.java does not exist under any test root
javax/swing/JTabbedPane/4666224/bug4666224.java 8144124  macosx-all

STDERR:
java.lang.AssertionError: 5 errors found while checking 13 problem list files
	at CheckProblemLists.main(CheckProblemLists.java:96)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
	at java.base/java.lang.Thread.run(Thread.java:1575)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330755: ProblemList files have entries referring to non-existent tests (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18879/head:pull/18879
$ git checkout pull/18879

Update a local copy of the PR:
$ git checkout pull/18879
$ git pull https://git.openjdk.org/jdk.git pull/18879/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18879

View PR using the GUI difftool:
$ git pr show -t 18879

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18879.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[mlbridge]

Webrevs

• 01: Full - Incremental (22ffae05)
• 00: Full (49a1a58e)

[magicus]

/label -build hotspot core-libs

[openjdk]

@magicus
The hotspot label was successfully added.

The core-libs label was successfully added.

The build label was successfully removed.

[dougxc]

I've removed CheckProblemLists.java as it overlaps with https://bugs.openjdk.org/browse/CODETOOLS-7903659.

[LudwikJaniuk]

While not a blocker IMO, I'm curious about the issues for the removed lines. Taking the first one as an example, I see it's "unresolved" (JDK-8192647) but the file was removed in JDK-8289764.
I don't see any other mentions of "problemlist" in JDK-8192647 so the "problemlist" label should probably also be removed.

I think it would be good to just do a check through the other issues and see if any other bookkeeping needs to be done, or if any surprises pop up.

[dougxc]

While not a blocker IMO, I'm curious about the issues for the removed lines. Taking the first one as an example, I see it's "unresolved" (JDK-8192647) but the file was removed in JDK-8289764. I don't see any other mentions of "problemlist" in JDK-8192647 so the "problemlist" label should probably also be removed.

I think it would be good to just do a check through the other issues and see if any other bookkeeping needs to be done, or if any surprises pop up.

Ok, I'm pinging people here who git blame associates with some of the removed entries: @walulyai , @lmesnik @kumarabhi006

However, I don't see how removing these entries can cause any problems. Someone would have noticed failing problem listed tests by now.

[kevinjwalls]

The tidyup looks good!

I don't understand that this is titled as JDK-8330755 but that's already integrated. So this needs to be done in a separate JBS entry and if the suggested CheckProblemLists.java is not going to be in it, we remove that from the description.

[dougxc]

The issue was resolved when I merged the PR to clean up the closed problem lists.

I'll just close this PR and leave it as documentation for future open ProblemList cleanup if someone wants to take it on.