8331401: G1: Make G1HRPrinter AllStatic

[tschatzl]

Hi all,

the HRPrinter does not have any member variables (static or non-static), so it can be made AllStatic.

I.e. there is no reason to have an instance variable around.

Testing: gha

Hth,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331401: G1: Make G1HRPrinter AllStatic (Enhancement - P4)

Reviewers

• Ivan Walulya (@walulyai - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Guoxiong Li (@lgxbslgx - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19058/head:pull/19058
$ git checkout pull/19058

Update a local copy of the PR:
$ git checkout pull/19058
$ git pull https://git.openjdk.org/jdk.git pull/19058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19058

View PR using the GUI difftool:
$ git pr show -t 19058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19058.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331401: G1: Make G1HRPrinter AllStatic

Reviewed-by: iwalulya, ayang, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 8bc641e: 8331404: IGV: Show line numbers for callees in properties
• 7c1fad4: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 6bef047: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize
• 01125fa: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
• 04271df: 8331331: :tier1 target explanation in doc/testing.md is incorrect
• f6cdcc6: 8280988: [XWayland] Click on title to request focus test failures
• 99654ec: 8331516: Tests should not use the "Classpath" exception form of the legal header
• cd3a607: 8328864: NullPointerException in sun.security.jca.ProviderList.getService()
• 73cdc9a: 8326421: Add jtreg test for large arrayCopy disjoint case.
• e2c0cfe: 8331320: ClassFile API OutOfMemoryError with certain class files
• ... and 18 more: https://git.openjdk.org/jdk/compare/286cbf831c2eb76e31bd69b4a93cd5ae9a821493...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3e233bf8)

[tschatzl]

Thanks @lgxbslgx @albertnetymk @walulyai for your reviews

/integrate

[openjdk]

Going to push as commit 8ed3190.
Since your change was applied there have been 33 commits pushed to the master branch:

• 1f6d38f: 8294978: Convert 5 test/jdk/jdk/jfr tests from ASM library to Classfile API
• c60474b: 8323707: Adjust Classfile API's type arg model to better represent the embodied type
• f78fa05: 8331636: [BACKOUT] Build failure after 8330076
• f665e07: 8331540: [BACKOUT] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API
• a10845b: 8330539: Use #include <alloca.h> instead of -Dalloca'(size)'=__builtin_alloca'(size)' for AIX
• 8bc641e: 8331404: IGV: Show line numbers for callees in properties
• 7c1fad4: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 6bef047: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize
• 01125fa: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
• 04271df: 8331331: :tier1 target explanation in doc/testing.md is incorrect
• ... and 23 more: https://git.openjdk.org/jdk/compare/286cbf831c2eb76e31bd69b4a93cd5ae9a821493...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 8ed3190.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.