Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332683: G1: G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors #19365

Closed

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented May 23, 2024

Hi all,

Please review this change to fix ubsan triggered errors on access to VLA entries in G1CardSetArray.

Testing: Tier 1-3

  • Local testing on Mac with --enable-ubsan.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332683: G1: G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19365/head:pull/19365
$ git checkout pull/19365

Update a local copy of the PR:
$ git checkout pull/19365
$ git pull https://git.openjdk.org/jdk.git pull/19365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19365

View PR using the GUI difftool:
$ git pr show -t 19365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19365.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2024

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2024

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332683: G1: G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 1b8dea4: 8332894: ubsan: vmError.cpp:2090:26: runtime error: division by zero
  • 0e7ea39: 8332678: Serial: Remove use of should_clear_all_soft_refs in serial folder
  • 72fbfe1: 8330577: G1 sometimes sends jdk.G1HeapRegionTypeChange for non-changes
  • 0889155: 8332885: Clarify failure_handler self-tests
  • 7f0ad51: 8332898: failure_handler: log directory of commands
  • 617edf3: 8332497: javac prints an AssertionError when annotation processing runs on program with module imports
  • ffa4bad: 8332527: ZGC: generalize object cloning logic
  • a3a367e: 8332871: Parallel: Remove public bits APIs in ParMarkBitMap
  • 61db2f5: 8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0
  • a083364: 8321292: SerialGC: NewSize vs InitialHeapSize check has an off-by-one error
  • ... and 39 more: https://git.openjdk.org/jdk/compare/4e6d851f3f061b4a9c2b5d2e3fba6a0277ac1f34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 23, 2024

@walulyai The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 23, 2024
@walulyai walulyai changed the title 8332683: G1 : G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors. 8332683: G1 : G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors May 23, 2024
@walulyai walulyai marked this pull request as ready for review May 23, 2024 11:55
@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2024
@mlbridge
Copy link

mlbridge bot commented May 23, 2024

Webrevs

@walulyai walulyai changed the title 8332683: G1 : G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors 8332683: G1: G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors May 27, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 27, 2024
@walulyai
Copy link
Member Author

Thanks @albertnetymk and @tschatzl for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2024

Going to push as commit 891d5ae.
Since your change was applied there have been 50 commits pushed to the master branch:

  • f3d6fbf: 8330847: G1 accesses uninitialized memory when predicting eden copy time
  • 1b8dea4: 8332894: ubsan: vmError.cpp:2090:26: runtime error: division by zero
  • 0e7ea39: 8332678: Serial: Remove use of should_clear_all_soft_refs in serial folder
  • 72fbfe1: 8330577: G1 sometimes sends jdk.G1HeapRegionTypeChange for non-changes
  • 0889155: 8332885: Clarify failure_handler self-tests
  • 7f0ad51: 8332898: failure_handler: log directory of commands
  • 617edf3: 8332497: javac prints an AssertionError when annotation processing runs on program with module imports
  • ffa4bad: 8332527: ZGC: generalize object cloning logic
  • a3a367e: 8332871: Parallel: Remove public bits APIs in ParMarkBitMap
  • 61db2f5: 8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0
  • ... and 40 more: https://git.openjdk.org/jdk/compare/4e6d851f3f061b4a9c2b5d2e3fba6a0277ac1f34...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2024
@openjdk openjdk bot closed this May 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2024
@openjdk
Copy link

openjdk bot commented May 27, 2024

@walulyai Pushed as commit 891d5ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants