8333303: Issues with DottedVersion class

[alexeysemenyukoracle]

• Get rid of DottedVersion#greedy field.
• Add support to save the unrecognizable remainder of the version string (required to handle Wix4 version string).
• Implement DottedVersion#equals().
• add DottedVersion#compareComponents(DottedVersion, DottedVersion) that compares recognized components of the given DottedVersion instances.
• remove DottedVersion#compareTo(String)

Edit
Delete

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333303: Issues with DottedVersion class (Bug - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19488/head:pull/19488
$ git checkout pull/19488

Update a local copy of the PR:
$ git checkout pull/19488
$ git pull https://git.openjdk.org/jdk.git pull/19488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19488

View PR using the GUI difftool:
$ git pr show -t 19488

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19488.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333303: Issues with DottedVersion class

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 3634a91: 8332751: Broken link in VirtualMachine.html
• ffb0867: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent
• 79f4998: 8321314: Reinstate disabling the compiler's default active annotation processing
• ec88c6a: 8332917: failure_handler should execute gdb "info threads" command on linux
• b3e29db: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization
• 11e926c: 8332777: Update JCStress test suite
• 44c1845: 8330852: All callers of JvmtiEnvBase::get_threadOop_and_JavaThread should pass current thread explicitly
• 922e312: 8328611: Thread safety issue in com.sun.tools.jdi.ReferenceTypeImpl::classObject
• 1d889e5: 8332487: Regression in Crypto-AESGCMBench.encrypt (and others) after JDK-8328181
• 32636dc: 8333105: Shenandoah: Results of concurrent mark may be lost for degenerated cycle
• ... and 16 more: https://git.openjdk.org/jdk/compare/bc7d9e3d0bc663bbbeb068889082da4a9f0fa8de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[alexeysemenyukoracle]

@sashamatveev please review

[mlbridge]

Webrevs

• 00: Full (d35412bb)

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 1b7d59f.
Since your change was applied there have been 27 commits pushed to the master branch:

• e304a8a: 8333307: Don't suppress jpackage logging in tests when it is detecting packaging tools in the system
• 3634a91: 8332751: Broken link in VirtualMachine.html
• ffb0867: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent
• 79f4998: 8321314: Reinstate disabling the compiler's default active annotation processing
• ec88c6a: 8332917: failure_handler should execute gdb "info threads" command on linux
• b3e29db: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization
• 11e926c: 8332777: Update JCStress test suite
• 44c1845: 8330852: All callers of JvmtiEnvBase::get_threadOop_and_JavaThread should pass current thread explicitly
• 922e312: 8328611: Thread safety issue in com.sun.tools.jdi.ReferenceTypeImpl::classObject
• 1d889e5: 8332487: Regression in Crypto-AESGCMBench.encrypt (and others) after JDK-8328181
• ... and 17 more: https://git.openjdk.org/jdk/compare/bc7d9e3d0bc663bbbeb068889082da4a9f0fa8de...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 1b7d59f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.